Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] currency_rate_update_xe: Migration to 16.0 #193

Merged
merged 8 commits into from
Apr 11, 2024

Conversation

mpascuall
Copy link
Contributor

@mpascuall mpascuall commented Apr 10, 2024

Module migrated to version 16.0

cc https://github.com/APSL 153469

@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 please review

Ernesto Tejeda and others added 6 commits April 8, 2024 10:58
Currently translated at 100.0% (4 of 4 strings)

Translation: currency-15.0/currency-15.0-currency_rate_update_xe
Translate-URL: https://translation.odoo-community.org/projects/currency-15-0/currency-15-0-currency_rate_update_xe/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: currency-15.0/currency-15.0-currency_rate_update_xe
Translate-URL: https://translation.odoo-community.org/projects/currency-15-0/currency-15-0-currency_rate_update_xe/
@pedrobaeza
Copy link
Member

/ocabot migration currency_rate_update_xe

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Apr 10, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 10, 2024
3 tasks
@mpascuall mpascuall force-pushed the 16.0-mig-currency_rate_update_xe branch from 39e5933 to 83c5a5f Compare April 10, 2024 11:42
Copy link

@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review ok

Copy link

@javierobcn javierobcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok , checked in runboat

@@ -3,7 +3,7 @@

{
"name": "Currency Rate Update: XE.com",
"version": "15.0.1.0.0",
"version": "16.0.1.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change (and the corresponding README modifications) should be done on the migration commit, not in the pre-commit auto-fixes.

Copy link
Contributor Author

@mpascuall mpascuall Apr 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, please review

@mpascuall mpascuall force-pushed the 16.0-mig-currency_rate_update_xe branch from 83c5a5f to ab4f3b3 Compare April 11, 2024 10:38
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-193-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit d572ba3 into OCA:16.0 Apr 11, 2024
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 543e988. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants