[16.0][IMP] dms: Show all directories in searchpanel from files #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TT46388 [FIX] dms: Set the correct parent_id of directories in searchpanel If the parent directory is not in all the records we should not set parent_id because the user does not have access to parent. TT46388 [FIX] dms: Avoid error when filtering in files If we filter on files (for example by name) we should not apply kwargs search_domain because we would be incorrectly filtering the directories by name, and we should always list them all. TT46903
chienandalu
reviewed
Jan 5, 2024
pedrobaeza
approved these changes
Jan 5, 2024
… (similar to v15) In the migration to 16.0 this behavior was removed by mistake and was only done in directories OCA@05f7c67#diff-1bb531d306f9014026b38b47879cd2cc7bcb1deaebb7466327f4483a0a459fc3R25
Oops, thanks, that's solved (I thought this was the same as in v15). |
|
/ocabot merge patch Please check if all other changes of 15.0 are reflected in this version. |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 9278094. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FWP from 15.0: #274 + #276 + #278
Show all directories in searchpanel from files
In v13 the
search_panel_select_range()method (https://github.com/odoo/odoo/blob/13.0/addons/web/models/models.py#L240) returned all directories, now only records that have any files in any directory are returned (this causes that directories without files are not shown).v13:
Before:
After:
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT46388