Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] fleet_vehicle_log_fuel: Migration to 16.0 #142

Merged
merged 18 commits into from
Mar 7, 2024
Merged

[16.0][MIG] fleet_vehicle_log_fuel: Migration to 16.0 #142

merged 18 commits into from
Mar 7, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Mar 6, 2024 •
edited
Loading

Migration to 16.0

Changes done:

  • Squash administrative commits.
  • Set a lot of fields with readonly in some states.
  • Add buttons to change status in form view.
  • Auto-create a record of the vehicle when the fuel is done.
  • Add tests to check all use cases.

@Tecnativa TT48096

MiquelRForgeFlow and others added 17 commits March 6, 2024 17:08
@MiquelRForgeFlow @victoralmau
[ADD] fleet_vehicle_log_fuel
94b26be 
[UPD] Update fleet_vehicle_log_fuel.pot

[UPD] README.rst

[UPD] Update fleet_vehicle_log_fuel.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/
@mymage @victoralmau
Added translation using Weblate (Italian)
2871e77 
Translated using Weblate (Italian)

Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/
@francesco-ooops @victoralmau
Translated using Weblate (Italian)
87de90a 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/
@mymage @victoralmau
Translated using Weblate (Italian)
9ae2dc9 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/
@francesco-ooops @victoralmau
Translated using Weblate (Italian)
5f66465 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/
@mymage @victoralmau
Translated using Weblate (Italian)
12199b6 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/
@francesco-ooops @victoralmau
Translated using Weblate (Italian)
9ef4963 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/

Translated using Weblate (Italian)

Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/
@marcelsavegnago @victoralmau
Added translation using Weblate (Portuguese (Brazil))
3e99e69
@mymage @victoralmau
Translated using Weblate (Italian)
4bf1548 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/
@marcelsavegnago @victoralmau
Translated using Weblate (Portuguese (Brazil))
7b63fa2 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/pt_BR/
@francesco-ooops @victoralmau
Translated using Weblate (Italian)
c496b80 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-14.0/fleet-14.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-14-0/fleet-14-0-fleet_vehicle_log_fuel/it/

[UPD] README.rst
@alissonjns @victoralmau
[MIG] fleet_vehicle_log_fuel: Migration to 15.0
4e9a120 
[UPD] Update fleet_vehicle_log_fuel.pot

[BOT] post-merge updates
@Ivorra78 @victoralmau
Translated using Weblate (Spanish)
311f998 
Currently translated at 100.0% (85 of 85 strings)

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_log_fuel/es/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_log_fuel/

Translated using Weblate (Spanish)

Currently translated at 100.0% (86 of 86 strings)

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_log_fuel/es/
@mymage @victoralmau
Translated using Weblate (Italian)
695b1a2 
Currently translated at 100.0% (86 of 86 strings)

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_log_fuel/it/

[UPD] Update fleet_vehicle_log_fuel.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_log_fuel/
@pedrobaeza @victoralmau
[FIX] fleet_vehicle_log_fuel: Don't replace whole SQL view + make it …
5c7da07 
…work + renaming

Replacing whole SQL view definition is totally incompatible with other
modules adding things to this report. We use a trick for replacing
only some parts retrieving the current SQL view for keeping the
inheritability.

We need as well to add the new selection value.

Finally, a renaming of the model file for proper recognition has been
done.

TT48062

[UPD] Update fleet_vehicle_log_fuel.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_log_fuel/
@mymage @victoralmau
Translated using Weblate (Italian)
ede25f7 
Currently translated at 100.0% (86 of 86 strings)

Translation: fleet-15.0/fleet-15.0-fleet_vehicle_log_fuel
Translate-URL: https://translation.odoo-community.org/projects/fleet-15-0/fleet-15-0-fleet_vehicle_log_fuel/it/
@victoralmau
[IMP] : pre-commit stuff
cebfffa
@pedrobaeza
Copy link
Member

/ocabot migration fleet_vehicle_log_fuel

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Mar 6, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 6, 2024
Open
12 tasks
@victoralmau victoralmau force-pushed the 16.0-mig-fleet_vehicle_log_fuel branch from 4ae834a to 63a6047 Compare March 7, 2024 07:35
@victoralmau
Copy link
Member Author

Changes done. Updated description explaining all changes that have been done.

carolinafernandez-tecnativa
carolinafernandez-tecnativa approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review LGTM :) Thanks!

marcelsavegnago
marcelsavegnago approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@marcelsavegnago marcelsavegnago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victoralmau victoralmau force-pushed the 16.0-mig-fleet_vehicle_log_fuel branch from 63a6047 to ff9d721 Compare March 7, 2024 14:05
@victoralmau victoralmau force-pushed the 16.0-mig-fleet_vehicle_log_fuel branch from ff9d721 to 6d0bb7c Compare March 7, 2024 14:06
pedrobaeza
pedrobaeza approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-142-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit ee86dd6 into OCA:16.0 Mar 7, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9e4a353. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-mig-fleet_vehicle_log_fuel branch March 7, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@carolinafernandez-tecnativa carolinafernandez-tecnativa carolinafernandez-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
10 participants
@victoralmau @pedrobaeza @OCA-git-bot @marcelsavegnago @carolinafernandez-tecnativa @MiquelRForgeFlow @mymage @francesco-ooops @alissonjns @Ivorra78