[17.0][IMP+FIX] intrastat_product: Improve company rules #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes done:
- Improve performance using [('company_id', 'in', company_ids + [False])]
- Change intrastat.product.declaration rule because company_id field is required.
- Add rules for intrastat.product.declaration.line and intrastat.product.computation.line
pedrobaeza
approved these changes
Nov 6, 2024
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at c69fb66. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve company rules
Changes done:
[('company_id', 'in', company_ids + [False])]intrastat.product.declarationrule becausecompany_idfield is required.intrastat.product.declaration.lineandintrastat.product.computation.line@Tecnativa