Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][FIX] Vista form en 123: Atributos states y attrs no funcionan bien juntos #3580

Merged
merged 1 commit into from
May 13, 2024
Merged

[16.0][FIX] Vista form en 123: Atributos states y attrs no funcionan bien juntos #3580

merged 1 commit into from
May 13, 2024

Conversation

EmilioPascual
Copy link
Contributor

Cuando el informe del 123 está en estado procesado, hecho o cancelado se ven los campos previos a la versión 2024 y los del 2024.
Este error es debido a que el attributo states a veces no funciona bien con el atributo attrs.
https://www.odoo.com/documentation/16.0/developer/reference/backend/views.html
image

@rafaelbn @pedrobaeza @HaraldPanten revisad por favor.

@moduon MT-6114

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@EmilioPascual
[FIX] l10n_es_aeat_mod123: view form with calculate and attrs with in…
fcba5e3 
…visible

When report was in state calculated, done or cancelled, domain invisible didn't work fine

MT-6114
@pedrobaeza pedrobaeza added this to the 16.0 milestone May 13, 2024
pedrobaeza
pedrobaeza approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Es correcto el cambio, aunque se opte por el = en lugar de not in, que sería la transcripción directa:

/ocabot merge minor

También a llevar a 17.0

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-3580-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 13, 2024
@OCA-git-bot
Merge PR #3580 into 16.0
3a82817 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-3580-by-pedrobaeza-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-3580-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7d1bb9b into OCA:16.0 May 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ee4d987. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten
Copy link
Contributor

Cuando el informe del 123 está en estado procesado, hecho o cancelado se ven los campos previos a la versión 2024 y los del 2024. Este error es debido a que el attributo states a veces no funciona bien con el atributo attrs. https://www.odoo.com/documentation/16.0/developer/reference/backend/views.html image

@rafaelbn @pedrobaeza @HaraldPanten revisad por favor.

@moduon MT-6114

Bien visto. Lo lleváis vosotros a V17 @EmilioPascual @rafaelbn ?

@EmilioPascual
Copy link
Contributor Author

Cuando el informe del 123 está en estado procesado, hecho o cancelado se ven los campos previos a la versión 2024 y los del 2024. Este error es debido a que el attributo states a veces no funciona bien con el atributo attrs. https://www.odoo.com/documentation/16.0/developer/reference/backend/views.html image
@rafaelbn @pedrobaeza @HaraldPanten revisad por favor.
@moduon Moduon - Task #6114

Bien visto. Lo lleváis vosotros a V17 @EmilioPascual @rafaelbn ?

@HaraldPanten no es necesario llevar este fix a v17 ya que para esa versión están obsoletas las etiquetas states y attrs y en el PR #3519 ya se tuvo en cuenta.

@HaraldPanten
Copy link
Contributor

OK!

@EmilioPascual EmilioPascual deleted the 16.0-fix_view_123 branch January 8, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EmilioPascual @OCA-git-bot @pedrobaeza @HaraldPanten