[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

manuelregidor · 2024-09-27T06:34:04Z

Supersedes: #3504

En esta migración se han incluido algunos cambios con respecto a v16:

Se ha eliminado la dependencia hacia el módulo queue_job. Ahora, el envío al SII se realiza a través de triggers, una opción base de Odoo.
Se han incluido las funcionalidades del módulo l10n_es_dua_sii (https://github.com/OCA/l10n-spain/tree/16.0/l10n_es_dua_sii), que en v17 ya no será necesario por haber pasado la gestión del DUA al módulo l10n-es.
Se ha eliminado el envío instantáneo cuando se valida una factura.

Quedará pendiente crear un nuevo campo sii_start_date en res.company, que serviría para que la función _compute_sii_enabled de sii.mixin lo tenga en cuenta para dar valor al campo sii_enabled.

T-5833

manuelregidor · 2024-09-27T06:41:30Z

@HaraldPanten @ValentinVinagre

HaraldPanten

Un par de comentarios, antes de revisarlo funcionalmente:

En el README (apartado DESCRIPTION) se sigue haciendo referencia al queue_job. Ese punto habría que quitarlo.
Puedes poner a Sygel como autores? Hemos hecho un buen refactoring y creo que es justo estar ahí. @pedrobaeza entiendo que no hay problema en ello, no?

Gracias!

pedrobaeza · 2024-09-27T06:59:27Z

Estoy de acuerdo con la co-autoría en este caso. Bien es cierto que AuresTIC (cc @zamberjo) por trabajos pasados también la merece.

manuelregidor · 2024-09-27T07:50:15Z

@HaraldPanten Cambios aplicados. En cuanto a los autores, he añadido a Sygel. Si finalmente tengo que añadir a AuresTIC, lo hago en un momento.

pedrobaeza · 2024-09-27T07:54:45Z

Incluid por favor #3736

manuelregidor · 2024-09-27T07:59:40Z

@pedrobaeza incluido

pedrobaeza · 2024-09-28T08:50:42Z

/ocabot migration l10n_es_aeat_sii_oca

Habría que incluir (adaptando) #3740 para los nuevos impuestos de octubre.

pedrobaeza · 2024-09-28T20:45:00Z

Para incluir también #3741, y se pueden juntar ambos commits, ya que es un leftover del primero.

manuelregidor · 2024-09-30T06:35:07Z

@pedrobaeza commits añadidos

pedrobaeza · 2024-10-09T10:51:54Z

Incluye por favor #3759, y a ver si esta semana lo puedo revisar ya para fusionarlo.

manuelregidor · 2024-10-09T13:33:31Z

@pedrobaeza commit #3759 añadido

Jesarregui

Functional Review: LGTM

HaraldPanten

Seems to be OK.

HaraldPanten

Disculpad, para el SII vamos a añadir la compatibilidad con DUA (impuestos que ya llevan en el core) en este mismo módulo, no me acordaba.

Queda este aspecto pendiente.

Jesarregui

Functional Review: LGTM

manuelregidor · 2024-11-06T08:02:45Z

@pedrobaeza @etobella @acysos Ya se puede revisar.

Steps to reproduce: - Enable SII in a company with connector with a delay of 48 hours. - Create and validate an invoice. A job is configured for being executed in 48 hours. - Next day, filter "Not sent to SII", and do Action > Send to SII. Result: the pending invoices are requeued and the delay is reapplied, so the invoices will be sent in 48 hours from that moment. Doing this indefinitely, the invoices will never be sent! Although it's a weird behavior, let's avoid it not requeuing the invoices with pending jobs. For this, a little refactor in the code has been done, not calling _cancel_sii_jobs, but filtering another way, and not removing previous failed jobs, which can be considered the only functional change, and it's not bad IMO. TT50641

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/

Creación de un nuevo modelo en `l10n_es_aeat` llamado *aeat_mixin*, del que heredan *sii.mixin* (ya existente) y un nuevo *verifactu.mixin*. Refactor de *sii.mixin* pasando funcionalidad a *aeat_mixin* Se han renombrado varios campos sii_* a aeat_* ya que serán utilizados por ambos.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/

Following odoo/odoo@fbc7214, this commit puts the new taxes on the corresponding SII maps for being able to send invoices containing them to the AEAT service. TT51016

Similar to OCA#3744 TT51159

…atibilities (hr_expense for example) Steps to reproduce: - Install hr_expense - Create a purchase type journal named Expenses and uncheck the Enable SII field. - Go to Expense > Configuration > Settings and define in Employee Expense Journal the Expenses journal previously created - Create an expense and an expense sheet - Click on the Submit to manager button - Click on the Approve button - Click on the Post journal entries button - The journal entry will be created correctly without any error TT51825

…abled field TT52143

ValentinVinagre · 2025-02-27T10:56:33Z

Disculpad, para el SII vamos a añadir la compatibilidad con DUA (impuestos que ya llevan en el core) en este mismo módulo, no me acordaba.

Queda este aspecto pendiente.

@HaraldPanten este PR está bloqueado por tu parte. ¿Que quedaría por realizar del DUA?

HaraldPanten · 2025-02-27T13:17:46Z

[MIG] l10n_es_aeat_sii_oca: Migration to v18 #4046

Lo del DUA ya se añadió. @AaronHForgeFlow Como estás haciendo la migración a V18, puedes revisar este PR primero?

Gracias.

AaronHForgeFlow · 2025-02-27T14:37:57Z

@HaraldPanten He hecho pruebas y no he encontrado ningún error. Sigo revisando los procesos, pero tengo poca experiencia en la localización y puede que se me escapen cosas.

AaronHForgeFlow · 2025-02-27T14:42:10Z

¿Podéis hacer commits separados para cada módulo? es más entendible luego a la hora de migrar. Supongo que los cambios en el modelo de ir.cron.trigger son necesarios en el módulo base de AEAT porque los usarán otros módulos de sii, facturae y demás.

manuelregidor · 2025-02-28T07:49:39Z

@AaronHForgeFlow Se ha separado la parte de los triggers del módulo l10n_es_aeat en otro commit.

ValentinVinagre

LGTM 👍🏻

HaraldPanten reviewed Sep 27, 2024

View reviewed changes

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 1fb8cbf to 7c0456a Compare September 27, 2024 07:49

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 7c0456a to fc0ea1f Compare September 27, 2024 07:58

OCA-git-bot added this to the 17.0 milestone Sep 28, 2024

OCA-git-bot mentioned this pull request Sep 28, 2024

Migration to version 17.0 #3298

Open

50 tasks

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch 2 times, most recently from ef7a702 to 7455920 Compare September 30, 2024 06:27

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 7455920 to 6511e98 Compare October 9, 2024 13:24

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 6511e98 to 69e97db Compare October 21, 2024 05:49

Jesarregui approved these changes Oct 22, 2024

View reviewed changes

HaraldPanten approved these changes Oct 22, 2024

View reviewed changes

OCA-git-bot added the approved label Oct 22, 2024

HaraldPanten requested changes Oct 23, 2024

View reviewed changes

OCA-git-bot removed the approved label Oct 23, 2024

HaraldPanten self-requested a review October 30, 2024 14:34

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch 3 times, most recently from 82c6319 to 2467f8e Compare November 4, 2024 17:08

Jesarregui approved these changes Nov 6, 2024

View reviewed changes

OCA-git-bot and others added 15 commits February 24, 2025 11:24

[BOT] post-merge updates

c9c47e6

[UPD] Update l10n_es_aeat_sii_oca.pot

fb24be3

[BOT] post-merge updates

2ec94d4

Update translation files

cae9094

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/

[UPD] Update l10n_es_aeat_sii_oca.pot

c318ae0

[BOT] post-merge updates

f0feb41

Update translation files

a3a6f65

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-16.0/l10n-spain-16.0-l10n_es_aeat_sii_oca Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-16-0/l10n-spain-16-0-l10n_es_aeat_sii_oca/

[IMP] l10n_es_aeat_sii_oca: send with quarters only for voluntary

4fb73f9

[IMP] l10n_es_aeat_sii_oca: Updated taxes october 2024

7f1d144

Following odoo/odoo@fbc7214, this commit puts the new taxes on the corresponding SII maps for being able to send invoices containing them to the AEAT service. TT51016

[FIX] l10n_es_aeat_sii_oca: Take into account inactive tax templates

d9204d9

Similar to OCA#3744 TT51159

[IMP] l10n_es_aeat_sii_oca: Improve SII not sent filter to use sii_en…

a0cd3fd

…abled field TT52143

[IMP] l10n_es_aeat_sii_oca: black, isort, prettier

6e5d094

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from 96cda40 to f31ee12 Compare February 24, 2025 10:24

Tisho99 mentioned this pull request Feb 24, 2025

[17.0][MIG] l10n_es_aeat_sii_oss: Migration to 17.0 #4038

Open

AaronHForgeFlow mentioned this pull request Feb 25, 2025

[MIG] l10n_es_aeat_sii_oca: Migration to v18 #4046

Draft

1 task

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from f31ee12 to aadcf51 Compare February 27, 2025 11:39

HaraldPanten approved these changes Feb 27, 2025

View reviewed changes

manuelregidor added 3 commits February 28, 2025 08:48

[IMP]l10n_es_aeat: sending triggers control general methods

f56f910

[MIG]l10n_es_aeat_sii_oca: Migration to 17.0

a4c18fc

[IMP]l10n_es_aeat_sii_oca: sii con DUA

f0d99ee

manuelregidor force-pushed the 17.0-mig-l10n_es_aeat_sii_oca branch from aadcf51 to f0d99ee Compare February 28, 2025 07:48

ValentinVinagre approved these changes Feb 28, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

manuelregidor commented Sep 27, 2024 •

edited

Loading

manuelregidor commented Sep 27, 2024

HaraldPanten left a comment

pedrobaeza commented Sep 27, 2024

manuelregidor commented Sep 27, 2024

pedrobaeza commented Sep 27, 2024

manuelregidor commented Sep 27, 2024

pedrobaeza commented Sep 28, 2024

pedrobaeza commented Sep 28, 2024

manuelregidor commented Sep 30, 2024

pedrobaeza commented Oct 9, 2024

manuelregidor commented Oct 9, 2024

Jesarregui left a comment

HaraldPanten left a comment

HaraldPanten left a comment

Jesarregui left a comment

manuelregidor commented Nov 6, 2024

ValentinVinagre commented Feb 27, 2025

HaraldPanten commented Feb 27, 2025

AaronHForgeFlow commented Feb 27, 2025

AaronHForgeFlow commented Feb 27, 2025

manuelregidor commented Feb 28, 2025

ValentinVinagre left a comment

[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

Are you sure you want to change the base?

[17.0][MIG] l10n_es_aeat_sii_oca: Migration to v17 #3737

Conversation

manuelregidor commented Sep 27, 2024 • edited Loading

manuelregidor commented Sep 27, 2024

HaraldPanten left a comment

Choose a reason for hiding this comment

pedrobaeza commented Sep 27, 2024

manuelregidor commented Sep 27, 2024

pedrobaeza commented Sep 27, 2024

manuelregidor commented Sep 27, 2024

pedrobaeza commented Sep 28, 2024

pedrobaeza commented Sep 28, 2024

manuelregidor commented Sep 30, 2024

pedrobaeza commented Oct 9, 2024

manuelregidor commented Oct 9, 2024

Jesarregui left a comment

Choose a reason for hiding this comment

HaraldPanten left a comment

Choose a reason for hiding this comment

HaraldPanten left a comment

Choose a reason for hiding this comment

Jesarregui left a comment

Choose a reason for hiding this comment

manuelregidor commented Nov 6, 2024

ValentinVinagre commented Feb 27, 2025

HaraldPanten commented Feb 27, 2025

AaronHForgeFlow commented Feb 27, 2025

AaronHForgeFlow commented Feb 27, 2025

manuelregidor commented Feb 28, 2025

ValentinVinagre left a comment

Choose a reason for hiding this comment

manuelregidor commented Sep 27, 2024 •

edited

Loading