Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][FIX] l10n_es_aeat_mod390: computation of fields 97 and 662 #3990

Merged
merged 1 commit into from
Feb 24, 2025
Merged

[17.0][FIX] l10n_es_aeat_mod390: computation of fields 97 and 662 #3990

merged 1 commit into from
Feb 24, 2025

Conversation

EmilioPascual
Copy link
Contributor

Fw-port de #3960

@moduon

@OCA-git-bot
Copy link
Contributor

Hi @pedrobaeza,
some modules you are maintaining are being modified, check this out!

@EmilioPascual EmilioPascual mentioned this pull request Feb 4, 2025
Merged
rafaelbn
rafaelbn approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FW Port already merged in 16

👍🏼

@EmilioPascual EmilioPascual force-pushed the 17.0-l10n_es_aeat_mod190-fw-port_pr_3960 branch from 0b84c89 to d5f6357 Compare February 24, 2025 15:16
@pedrobaeza pedrobaeza added this to the 17.0 milestone Feb 24, 2025
pedrobaeza
pedrobaeza approved these changes Feb 24, 2025
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-3990-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 24, 2025
@OCA-git-bot
Merge PR #3990 into 17.0
41d0e80 
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-3990-by-pedrobaeza-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3990-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1aafbef. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit c74e843 into OCA:17.0 Feb 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
5 participants
@EmilioPascual @OCA-git-bot @pedrobaeza @rafaelbn @LauraCForgeFlow