[17.0][FIX] l10n_es_aeat_mod*: Fix tests related to S_IVA21ISP #3996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tax S_IVA21ISP was removed at odoo/odoo@401a961 therefore, the test data is incorrect. If tax S_IVA21ISP is restored, this change must be reverted.
|
Hi @pedrobaeza, |
victoralmau
force-pushed
the
17.0-fix-l10n_es_aeat_mod390-tests-S_IVA21ISP
branch
2 times, most recently
from
c78d60a to
df108c8
Compare
Tax S_IVA21ISP was removed at odoo/odoo@401a961 therefore, the test data is incorrect. If tax S_IVA21ISP is restored, this change must be reverted.
Tax S_IVA21ISP was removed at odoo/odoo@401a961 therefore, the test data is incorrect. If tax S_IVA21ISP is restored, this change must be reverted.
victoralmau
force-pushed
the
17.0-fix-l10n_es_aeat_mod390-tests-S_IVA21ISP
branch
from
df108c8 to
7305e92
Compare
|
Los intracomunitarios y extracomunitarios han cambiado de nombre, no? |
Revisando los cambios de odoo/odoo@401a961 y lo que se ha restituido en odoo/odoo@67e1977 no veo ningún cambio al respecto. |
EmilioPascual
approved these changes
Feb 7, 2025
|
¿Alguna novedad? ¿Puedo ayudar en algo? ¿Les envio un jamon de pata negra a Odoo o que? |
Odoo has renamed the intra-community tax for goods from *_s_iva0_ic to *_s_iva0_g_i.
pedrobaeza
force-pushed
the
17.0-fix-l10n_es_aeat_mod390-tests-S_IVA21ISP
branch
from
7305e92 to
cf4697e
Compare
GLS is now returning error continuously, so we can't do real tests against its API.
|
/ocabot merge patch @Tardo mi dirección ya la conoces para el envío del jamón 😉 |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 071346a. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrección de los tests relacionado con el impuesto S_IVA21ISP
Cambios realizados en:
l10n_es_facturael10n_es_aeat_mod303l10n_es_aeat_mod349l10n_es_aeat_mod390El impuesto S_IVA21ISP se ha eliminado en odoo/odoo@401a961 por lo tanto, los tests fallan al esperar unos valores específicos.
Si el impuesto S_IVA21ISP se restaura, estos cambios se deberán revertir.
@Tecnativa