Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][MIG] l10n_es_vat_book_oss: Migration to 17.0 #4010

Merged
merged 19 commits into from
Feb 28, 2025

Conversation

Tisho99
Copy link
Contributor

@Tisho99 Tisho99 commented Feb 12, 2025

Standard migration

T-7533

@Tisho99 Tisho99 force-pushed the 17.0-mig-l10n_es_vat_book_oss branch from bf0613e to 806f788 Compare February 18, 2025 16:31
@Tisho99 Tisho99 marked this pull request as ready for review February 19, 2025 08:08
@manuelregidor
Copy link
Contributor

@Tisho99 Could you rebase, please?

@Tisho99 Tisho99 force-pushed the 17.0-mig-l10n_es_vat_book_oss branch from 806f788 to c767441 Compare February 25, 2025 08:12
Copy link
Contributor

@Jesarregui Jesarregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review: LGTM

Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

@HaraldPanten
Copy link
Contributor

@Tisho99 could you rebase in order to check tests?

@Tisho99 Tisho99 force-pushed the 17.0-mig-l10n_es_vat_book_oss branch from c767441 to 54356b6 Compare February 28, 2025 08:16
@Tisho99
Copy link
Contributor Author

Tisho99 commented Feb 28, 2025

@HaraldPanten Done!

@HaraldPanten
Copy link
Contributor

/ocabot migration l10n_es_vat_book_oss

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Feb 28, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 28, 2025
50 tasks
Copy link
Contributor

@HaraldPanten HaraldPanten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vamos a darle salida rápida a este módulo que es relativamente sencillo.

@HaraldPanten
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-4010-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f350c77 into OCA:17.0 Feb 28, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4d7050e. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 17.0-mig-l10n_es_vat_book_oss branch February 28, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants