[16.0][FIX] l10n_es_aeat_mod303: Avoid negatives in fee to compensate #4048
Conversation
|
Hay que corregir los tests del 303 y del 390 |
|
Sí, tengo que ver qué están haciendo esos tests y por qué fallan. Creo que es porque simplemente comprueba los valores que tocaban antes según la expresión aritmética, pero tal vez hay un caso legítimo que me estoy dejando. |
pedrobaeza
force-pushed
the
16.0-fix-l10n_es_aeat_mod303-potential_cuota_compensar
branch
from
5d3c7a7 to
8af639e
Compare
If the previous 303 report has remaining fee to compensate, and the result of the report is positive and bigger than the fee to compensate, when computing the current one, the constraint "The fee to compensate must be indicated as a positive number." will raise always. To avoid it, two changes have been done: 1. Only substract report result if it's of type C. 2. Nullify any possible result when it's less than 0. Amendment of 4bd1c02 TT55245
pedrobaeza
force-pushed
the
16.0-fix-l10n_es_aeat_mod303-potential_cuota_compensar
branch
from
8af639e to
d150e2d
Compare
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-4048-by-pedrobaeza-bump-patch. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 8f1e36c. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-fix-l10n_es_aeat_mod303-potential_cuota_compensar
branch
If the previous 303 report has remaining fee to compensate, and the result of the report is positive and bigger than the fee to compensate, when computing the current one, the constraint
"The fee to compensate must be indicated as a positive number."
will raise always.
To avoid it, two changes have been done:
Amendment of 4bd1c02
@Tecnativa TT55245