Skip to content

Commit

Permalink
[FIX] po-pretty-format: Allow original=translated term for "i18n_extr…
Browse files Browse the repository at this point in the history
…a" folder (#113)

Autofix is clearing the translations where the original term is the same than translated one

e.g.

msgid "CRM"
msgstr "CRM"  --> ""

However, there are valid cases to reset the translated value

But it should be only for i18n_extra folder

More info #100
  • Loading branch information
moylop260 authored Dec 5, 2024
1 parent 7cc4cf0 commit 1fb2d47
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/oca_pre_commit_hooks/checks_odoo_module_po.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,11 @@ def __init__(self, po_filename, enable, disable, autofix):

def _compute_pretty_contents(self):
self.po_data.sort(key=lambda entry: entry.msgid)
for entry in self.po_data:
if entry.msgid == entry.msgstr:
entry.msgstr = ""
# Ignore i18n_extra https://github.com/OCA/odoo-pre-commit-hooks/issues/100
if self.data_section != "i18n_extra":
for entry in self.po_data:
if entry.msgid == entry.msgstr:
entry.msgstr = ""

self.pretty_contents = str(self.po_data)

Expand Down
19 changes: 19 additions & 0 deletions test_repo/test_module/i18n_extra/fr.po
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# Translation of Odoo Server.
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server\n"
"Report-Msgid-Bugs-To: \n"
"POT-Creation-Date: 1985-04-14 17:12+0000\n"
"PO-Revision-Date: 1985-04-14 02:03+0000\n"
"Last-Translator: Moisés López <moylop260@vauxoo.com>\n"
"Language-Team: \n"
"MIME-Version: 1.0\n"
"Content-Type: text/plain; charset=UTF-8\n"
"Content-Transfer-Encoding: \n"
"Plural-Forms: \n"

#. module: test_module
#: model:ir.model.fields,field_description:test_module.field_description
#, python-format
msgid "same msgid msgstr allowed for i18n_extra"
msgstr "same msgid msgstr allowed for i18n_extra"

0 comments on commit 1fb2d47

Please sign in to comment.