False Positive: "Duplicate PO message definition" for Contextually Different Translations

[Ahmed-Maghraoui-Eezee-It]

Module

hook id: oca-checks-po

Describe the bug

The Odoo pre-commit hook for .po[t] files incorrectly flags valid translations as duplicates when they have different msgstr values.

To Reproduce

Create a .po file with multiple translations for the same msgid, each with different msgstr values.

e.g :

Translation 1

msgid "Submitted"
msgstr "Soumis"

Translation 2

msgid "Submitted"
msgstr "Soumise"

Expected behavior
The pre-commit hook should not flag different msgstr values for the same msgid as duplicates when they represent valid translations in different contexts.

[luisg123v]

I think the described behavior is expected, because Odoo doesn't support providing different translations for the same term. In fact, if the translation file is re-exported, those will be lost and a single one will be included.

[moylop260]

@Ahmed-Maghraoui-Eezee-It

Could you export the PO file in order to double-confirm that Luis said, please?

[Ahmed-Maghraoui-Eezee-It]

@moylop260 @luisg123v
it's not the same term, the first translation is related to a view in the current custom module, and the second is related to a selection field in a standard module.
The translations are working fine and when I export the po file for each module I get different translations as expected.

[moylop260]

Could you share the po file and the odoo version, please?

[Ahmed-Maghraoui-Eezee-It]

odoo version 18

fr_BE.po.txt

[moylop260]

I have created a video with the following steps:

1. Export po file for Spanish for 2 modules (e.g. sale_management, account)
2. Open the po file and split the "active" msgid in 2 msgstr for different modules similar your example

...

-- ORIGINAL
#. modules: account, sale_management
#: model:ir.model.fields,field_description:account.field_account_account_tag__active
#: model:ir.model.fields,field_description:sale_management.field_sale_order_template__active
#: model:ir.model.fields.selection,name:account.selection__account_lock_exception__state__active
#: model_terms:ir.ui.view,arch_db:account.view_account_tax_search
msgid "Active"
msgstr "Activo"

...

-- EDITED
#. modules: account
#: model:ir.model.fields,field_description:account.field_account_account_tag__active
#: model:ir.model.fields.selection,name:account.selection__account_lock_exception__state__active
#: model_terms:ir.ui.view,arch_db:account.view_account_tax_search
msgid "Active"
msgstr "Activo1"

#. modules: sale_management
#: model:ir.model.fields,field_description:sale_management.field_sale_order_template__active
msgid "Active"
msgstr "Activo2"

The diff

--- original
+++ edited
@@ -1,11 +1,11 @@
-...
-
-#. modules: account, sale_management
+#. modules: account
 #: model:ir.model.fields,field_description:account.field_account_account_tag__active
-#: model:ir.model.fields,field_description:sale_management.field_sale_order_template__active
 #: model:ir.model.fields.selection,name:account.selection__account_lock_exception__state__active
 #: model_terms:ir.ui.view,arch_db:account.view_account_tax_search
 msgid "Active"
-msgstr "Activo"
+msgstr "Activo1"

-...
+#. modules: sale_management
+#: model:ir.model.fields,field_description:sale_management.field_sale_order_template__active
+msgid "Active"
+msgstr "Activo2"

3. Re-import the file modified and check the changes were applied
4. Repeat step 1 (re-export in the same way)
5. Check the msgid was grouped and the second term was deleted

The new PO file looks like the original one

...

#. modules: account, sale_management
#: model:ir.model.fields,field_description:account.field_account_account_tag__active
#: model:ir.model.fields,field_description:sale_management.field_sale_order_template__active
#: model:ir.model.fields.selection,name:account.selection__account_lock_exception__state__active
#: model_terms:ir.ui.view,arch_db:account.view_account_tax_search
msgid "Active"
msgstr "Activo1"

...

See the video:

• 

Notice this is the purpose of the check, so it is a valid case.

Also, notice you are using a po file for 2 modules, so maybe it should be used in MODULE/i18n_extra/fr_be.po instead of MODULE/i18n/fr_be.po where you can maintain manually the po file without exporting and we can disable this check for this extra folder (It needs a change)

[luisg123v]

@Ahmed-Maghraoui-Eezee-It,

it's not the same term, the first translation is related to a view in the current custom module, and the second is related to a selection field in a standard module.

I think this is the source of the issue. Your file i18n/fr_BE.po is not intended to contain translations from other modules, only for the same module. When you re-export translations, you should only include translations from the module they're contained on. For translating other modules, you should use the i18n_extra folder.

Maybe we can disable the check for i18n_extra translations, as suggested by @moylop260, but I think you wouldn't need that change, unless you need to translate the same term of several other modules different from the custom one.

[moylop260]

Please, review:
#123

I have added a better message but I think it could be even better

Could you check it, please?

[Ahmed-Maghraoui-Eezee-It]

Thank you so much @moylop260 @luisg123v

Turns out adding the translations to the i18n_extra was exactly what I needed.
Sorry for the hassle, but I really appreciate your help!

[moylop260]

@Ahmed-Maghraoui-Eezee-It

Thank you for reporting the issue

IMHO it is a valid case

I only needed to understand it very well in order to know what was the best fix for that

It will be released in v0.1.1