-
-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] fastapi: Migration to 18.0 #471
Conversation
…pi service excution
* add default empty method to use as dependency to get the authenticated partner * improves the demo app to illustrate the way the dependency overrides mechanism can be used to provide the right implementation to use to retrieve the authenticated partner according to the security method configured on the app * add tests for the demo app to show how the TestClient class and the dependey overrides functianality should be used to easily write tests
This method can be used to get access to the fastapi.endpoint record into your router's methods
ensure transation is rolled back in case of error and allows override / extension of the error handling globally or by app
…thin fastapi apps
Co-authored-by: Fernando <fernandolachica@gmail.com>
…ted processing lang
A ribbon and a button are dislayed on the form view when a record needs to be synchronized. In the tree view the records to synchronize are displayed with the text decoration defined for warning. A button is also displayed on the line if sync is required and an server actions allows you to sync selected records in one click
In the same time, applies the security guidelines for the demo app
I'm not pretty sure, because if you can see test log, It seems every test works fine, but because log has an error text can't be processed as passed by CI, I think can be the parser version now aggregate another validation, maybe in older versions doesn't matter, We can ask to @pedrobaeza? WDYT? |
I don't know about this repository. @lmignon may say. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (Code + Functional review)
3d12799
to
56ede08
Compare
@lmignon I added in other test method, and now works, thank you for help |
56ede08
to
d960109
Compare
/ocabot migration fastapi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (waiting for the merge of the endpoint_route_handler
addon)
57944ca
to
4c718df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested with demo api
This PR has the |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at 7aad90c. Thanks a lot for contributing to OCA. ❤️ |
Change serialization error class to test retry failure
Depends on: