Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.0][MIG] fastapi: Migration to 18.0 #471

Merged
merged 118 commits into from
Feb 3, 2025
Merged

Conversation

cormaza
Copy link

@cormaza cormaza commented Nov 8, 2024

Change serialization error class to test retry failure

Depends on:

lmignon and others added 30 commits November 8, 2024 11:14
* add default empty method to use as dependency to get the authenticated partner
* improves the demo app to illustrate the way the dependency overrides mechanism can be used to provide the right implementation to use to retrieve the authenticated partner according to the security method configured on the app
* add tests for the demo app to show how the TestClient class and the dependey overrides functianality should be used to easily write tests
This method can be used to get access to the fastapi.endpoint record into your router's methods
ensure transation is rolled back in case of error and allows override / extension of the error handling globally or by app
Co-authored-by: Fernando <fernandolachica@gmail.com>
A ribbon and a button are dislayed on the form view when a record needs to be synchronized.
In the tree view the records to synchronize are displayed with the text decoration defined for warning. A button is also displayed on the line if sync is required and an server actions allows you to sync selected records in one click
In the same time, applies the security guidelines for the demo app
@cormaza
Copy link
Author

cormaza commented Nov 19, 2024

Hi @cormaza, thanks for the work. Do you have any idea on how to fix the tests?

I'm not pretty sure, because if you can see test log, It seems every test works fine, but because log has an error text can't be processed as passed by CI, I think can be the parser version now aggregate another validation, maybe in older versions doesn't matter, We can ask to @pedrobaeza? WDYT?

image

@pedrobaeza
Copy link
Member

I don't know about this repository. @lmignon may say.

Copy link
Contributor

@marielejeune marielejeune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code + Functional review)

@lmignon
Copy link
Contributor

lmignon commented Nov 19, 2024

@cormaza the commit 4dd16b2 should solve this issue.

@cormaza
Copy link
Author

cormaza commented Nov 19, 2024

@cormaza the commit 4dd16b2 should solve this issue.

Thank you, but doesn't work

@cormaza
Copy link
Author

cormaza commented Nov 19, 2024

@lmignon I added in other test method, and now works, thank you for help

@lmignon
Copy link
Contributor

lmignon commented Jan 30, 2025

/ocabot migration fastapi

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 30, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 30, 2025
18 tasks
Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (waiting for the merge of the endpoint_route_handler addon)

Copy link

@dnplkndll dnplkndll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with demo api

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@lmignon
Copy link
Contributor

lmignon commented Feb 3, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-471-by-lmignon-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7a0af6a into OCA:18.0 Feb 3, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7aad90c. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.