[14.0][FIX] auth_saml_environment: no require on readonly fields #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the usage of the form view by dropping the required condition on binary fields that are readonly. Those fields became mandatory after OCA/server-auth#342 but the module auth_saml_environment offer to use paths as a alternative config option for binaries thus those fields can be empty.
yvaucher
changed the title
gurneyalex
approved these changes
Jun 28, 2024
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 49912f9. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restore the usage of the form view by dropping the required condition on binary fields that are readonly.
Those fields became mandatory after OCA/server-auth#342 but the module auth_saml_environment offer to use paths as a alternative config option for binaries thus those fields can be empty.