Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][ADD] payment_environment #76

Merged
merged 1 commit into from
Nov 23, 2021
Merged

[13.0][ADD] payment_environment #76

merged 1 commit into from
Nov 23, 2021

Conversation

ivantodorovich
Copy link
Contributor

@ivantodorovich ivantodorovich commented Jul 5, 2021 •
edited
Loading

Configure payment acquirers with server_environment

@ivantodorovich ivantodorovich mentioned this pull request Jul 6, 2021
Merged
@ivantodorovich ivantodorovich force-pushed the 13.0-add-payment-env branch from 9310f9e to 1c1a0b7 Compare July 6, 2021 12:42
@simahawk
Copy link
Contributor

#77 is getting merged

@ivantodorovich
Copy link
Contributor Author

Thanks! PR updated accordignly :)

simahawk
simahawk reviewed Aug 18, 2021
View reviewed changes
simahawk
simahawk reviewed Aug 18, 2021
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivantodorovich I've just realized that this should probably go to https://github.com/OCA/?q=payment

@simahawk
Copy link
Contributor

@ivantodorovich ping :)

@ivantodorovich
Copy link
Contributor Author

@ivantodorovich I've just realized that this should probably go to https://github.com/OCA/?q=payment

Should it thought? 🤔

by the same logic, shouldn't mail_environment go to https://github.com/OCA/social; pos_environment go to https://github.com/OCA/pos; carrier_environment go to https://github.com/OCA/delivery-carrier; etc..

This is kind of a gray area I think 😅

@gurneyalex
Copy link
Member

I would keep this in OCA/server-env if you start using it, it's nice to have all the deps in 1 single place.

@gurneyalex
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-76-by-gurneyalex-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 93431f8 into OCA:13.0 Nov 23, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 643fb7f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk requested changes

@gurneyalex gurneyalex gurneyalex approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ivantodorovich @simahawk @gurneyalex @OCA-git-bot