[14.0][IMP] product_barcode_constraint_per_company: simplify logic #537

dessanhemrayev · 2023-10-21T21:26:20Z

Change old method
Update oca_dependencies file
Fix tests

product_barcode_constraint_per_company/__manifest__.py

product_barcode_constraint_per_company/README.rst

product_barcode_constraint_per_company/__manifest__.py

legalsylvain

Do not add new dependency to multi barcode module.

dessanhemrayev · 2023-10-24T21:14:57Z

Do not add new dependency to multi barcode module.

@legalsylvain Do you think we need to create a bridge module for that, or is there possibly another solution?

legalsylvain · 2023-10-24T21:23:50Z

multi barcode module is a module that is really changing a lot of things. The feature is not desired in some implementation. So in that case, indeed glue module looks a good solution, if you want to make the module product_barcode_constraint_per_company working with that module.

francesco-ooops · 2023-10-26T08:38:12Z

supersedes #526

legalsylvain

except the deletion of the README.rst file, LGTM. Thanks !

legalsylvain

nitpicking : still changes in product_barcode_constraint_per_company/README.rst !

No need to change this file, it will be generated automatically, when mergin the PR, by the bot.

regards.

geomer198

Please fix comments

product_barcode_constraint_per_company/tests/test_module.py

geomer198 · 2023-11-20T11:45:36Z

product_multi_barcode_constraint_per_company/models/product_barcode.py

+    @api.constrains("name")
+    def _check_duplicates(self):
+        for record in self:
+            barcodes = self.search(


Why you use search function here?
And why you call super in cycle?

Thanks, I'll fix it

geomer198 · 2023-11-20T11:47:17Z

product_multi_barcode_constraint_per_company/tests/test_product_barcode_constraint.py

+
+    def test_create_different_company(self):
+        """Verify creating a product with the same barcode for different companies"""
+        super().test_create_different_company()


You deactivate parent function. Why do you use super here?

Thanks, I'll fix it

geomer198 · 2023-11-20T11:47:50Z

product_multi_barcode_constraint_per_company/tests/test_product_barcode_constraint.py

+
+    def test_create_same_company(self):
+        """Verifying the Existence of a Product with the Same Barcode within a Single Company"""
+        super().test_create_same_company()


You deactivate parent function. Why do you use super here?

Thanks, I'll fix it

aleuffre

Code review, LGTM

francesco-ooops · 2024-01-03T10:56:52Z

@simahawk good for you?

francesco-ooops · 2024-01-08T09:06:03Z

@simahawk waiting for your blessing :)

francesco-ooops · 2024-01-12T09:37:51Z

@simahawk help me Orsi-Wan Kenobi, you're my only hope

francesco-ooops · 2024-01-16T09:40:44Z

@pedrobaeza can this be merged based on existing reviews?

pedrobaeza · 2024-01-16T10:07:55Z

product_barcode_constraint_per_company/README.rst

@@ -87,4 +87,4 @@ promote its widespread use.

 This module is part of the `OCA/stock-logistics-barcode <https://github.com/OCA/stock-logistics-barcode/tree/14.0/product_barcode_constraint_per_company>`_ project on GitHub.

-You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.


Remove this change.

pedrobaeza · 2024-01-16T10:08:12Z

product_barcode_constraint_per_company/__manifest__.py

-    "summary": "Change the product barcode constraint"
-    ", allowing the same barcode for differents companies",
+    "summary": """Change the product barcode constraint,
+                  allowing the same barcode for differents companies""",


Don't change this. It was correct. Now, it isn't, as the spaces are included.

Thanks for review!)
I'll fix it

product_barcode_constraint_per_company/__manifest__.py

simahawk

pls check Pedro's remarks

simahawk · 2024-01-16T10:47:03Z

product_barcode_constraint_per_company/__manifest__.py

@@ -6,13 +6,13 @@
    "name": "Product Barcode Constraint per Company",
    "version": "14.0.1.0.1",


Detail: as you added a new module in the same PR you should change the version manually here, unless you don't care that the new module will have version 1.1.0 too when we'll bump w/ minor.

simahawk · 2024-01-16T10:47:52Z

product_multi_barcode_constraint_per_company/models/product_barcode.py

+            if barcode and (
+                not record.product_id.company_id
+                or (
+                    barcode.sudo().product_id.company_id == record.product_id.company_id


I'd move sudo to for record in self.sudo()

Thanks for review!)
I'll fix it

francesco-ooops · 2024-01-26T08:44:19Z

@pedrobaeza @simahawk kind reminder :)

simahawk

minor remark, pre-approving

simahawk · 2024-01-26T10:02:55Z

product_barcode_constraint_per_company/README.rst

@@ -87,4 +87,4 @@ promote its widespread use.

 This module is part of the `OCA/stock-logistics-barcode <https://github.com/OCA/stock-logistics-barcode/tree/14.0/product_barcode_constraint_per_company>`_ project on GitHub.

-You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.
+You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.


Update oca_dependencies file Fix tests

dessanhemrayev · 2024-01-30T19:21:59Z

@pedrobaeza please check, I have corrected your comments)
Thanks

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-01-30T19:25:40Z

On my way to merge this fine PR!
Prepared branch 14.0-ocabot-merge-pr-537-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-01-30T19:31:40Z

Congratulations, your PR was merged at 67df8ca. Thanks a lot for contributing to OCA. ❤️

legalsylvain reviewed Oct 21, 2023

View reviewed changes

product_barcode_constraint_per_company/__manifest__.py Show resolved Hide resolved

legalsylvain approved these changes Oct 21, 2023

View reviewed changes

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch 4 times, most recently from bed05b5 to cddf5eb Compare October 21, 2023 22:12

legalsylvain reviewed Oct 22, 2023

View reviewed changes

product_barcode_constraint_per_company/README.rst Outdated Show resolved Hide resolved

legalsylvain reviewed Oct 22, 2023

View reviewed changes

product_barcode_constraint_per_company/__manifest__.py Outdated Show resolved Hide resolved

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch from cddf5eb to e879582 Compare October 22, 2023 12:50

legalsylvain suggested changes Oct 22, 2023

View reviewed changes

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch from e879582 to 524392e Compare October 24, 2023 21:18

dessanhemrayev requested a review from legalsylvain October 24, 2023 21:21

dessanhemrayev marked this pull request as draft October 29, 2023 09:44

dessanhemrayev mentioned this pull request Oct 30, 2023

[14.0][ADD] product_multi_barcode_constraint_per_company: add module #546

Closed

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch from 524392e to 7722d53 Compare October 30, 2023 20:25

dessanhemrayev marked this pull request as ready for review October 30, 2023 20:26

legalsylvain reviewed Oct 30, 2023

View reviewed changes

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch 2 times, most recently from bbb5f35 to 33bd632 Compare October 30, 2023 21:45

legalsylvain reviewed Oct 30, 2023

View reviewed changes

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch 4 times, most recently from a206cd3 to df61843 Compare November 1, 2023 19:17

geomer198 force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch from df61843 to 5431e29 Compare November 10, 2023 12:44

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch from 60bfe4b to 30a8ce8 Compare November 19, 2023 14:29

geomer198 suggested changes Nov 20, 2023

View reviewed changes

aleuffre approved these changes Jan 3, 2024

View reviewed changes

pedrobaeza added this to the 14.0 milestone Jan 16, 2024

pedrobaeza requested changes Jan 16, 2024

View reviewed changes

simahawk reviewed Jan 16, 2024

View reviewed changes

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch from e2713a1 to 92adfe2 Compare January 16, 2024 19:53

dessanhemrayev requested review from pedrobaeza and simahawk January 16, 2024 19:58

simahawk approved these changes Jan 26, 2024

View reviewed changes

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch 3 times, most recently from c6f40a7 to fed1a4c Compare January 30, 2024 18:55

dessanhemrayev added 2 commits January 30, 2024 19:13

[IMP] product_barcode_constraint_per_company: change old method

48fa209

Update oca_dependencies file Fix tests

[ADD] product_multi_barcode_constraint_per_company: new module

f1b5832

dessanhemrayev force-pushed the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch from fed1a4c to f1b5832 Compare January 30, 2024 19:13

pedrobaeza approved these changes Jan 30, 2024

View reviewed changes

OCA-git-bot added the approved label Jan 30, 2024

OCA-git-bot added the bot is merging ⏳ label Jan 30, 2024

OCA-git-bot merged commit 35b1346 into OCA:14.0 Jan 30, 2024
6 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jan 30, 2024

dessanhemrayev deleted the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch January 30, 2024 19:50

dessanhemrayev restored the 14.0-t2944-product_barcode_constraint_per_company-refactoring branch January 30, 2024 19:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][IMP] product_barcode_constraint_per_company: simplify logic #537

[14.0][IMP] product_barcode_constraint_per_company: simplify logic #537

dessanhemrayev commented Oct 21, 2023

legalsylvain left a comment

dessanhemrayev commented Oct 24, 2023 •

edited

Loading

legalsylvain commented Oct 24, 2023

francesco-ooops commented Oct 26, 2023

legalsylvain left a comment

legalsylvain left a comment

geomer198 left a comment

geomer198 Nov 20, 2023

dessanhemrayev Nov 20, 2023

geomer198 Nov 20, 2023

dessanhemrayev Nov 20, 2023

geomer198 Nov 20, 2023

dessanhemrayev Nov 20, 2023

aleuffre left a comment

francesco-ooops commented Jan 3, 2024

francesco-ooops commented Jan 8, 2024

francesco-ooops commented Jan 12, 2024

francesco-ooops commented Jan 16, 2024

pedrobaeza Jan 16, 2024

simahawk Jan 26, 2024

pedrobaeza Jan 16, 2024

dessanhemrayev Jan 16, 2024

simahawk left a comment

simahawk Jan 16, 2024

simahawk Jan 16, 2024

dessanhemrayev Jan 16, 2024

francesco-ooops commented Jan 26, 2024

simahawk left a comment

simahawk Jan 26, 2024

dessanhemrayev commented Jan 30, 2024

pedrobaeza left a comment

OCA-git-bot commented Jan 30, 2024

OCA-git-bot commented Jan 30, 2024

		@@ -6,13 +6,13 @@
		"name": "Product Barcode Constraint per Company",
		"version": "14.0.1.0.1",

[14.0][IMP] product_barcode_constraint_per_company: simplify logic #537

[14.0][IMP] product_barcode_constraint_per_company: simplify logic #537

Conversation

dessanhemrayev commented Oct 21, 2023

legalsylvain left a comment

Choose a reason for hiding this comment

dessanhemrayev commented Oct 24, 2023 • edited Loading

legalsylvain commented Oct 24, 2023

francesco-ooops commented Oct 26, 2023

legalsylvain left a comment

Choose a reason for hiding this comment

legalsylvain left a comment

Choose a reason for hiding this comment

geomer198 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

aleuffre left a comment

Choose a reason for hiding this comment

francesco-ooops commented Jan 3, 2024

francesco-ooops commented Jan 8, 2024

francesco-ooops commented Jan 12, 2024

francesco-ooops commented Jan 16, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francesco-ooops commented Jan 26, 2024

simahawk left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dessanhemrayev commented Jan 30, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 30, 2024

OCA-git-bot commented Jan 30, 2024

dessanhemrayev commented Oct 24, 2023 •

edited

Loading