Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] [FIX] stock_barcodes: restore read_inventory to old version #582

Merged
merged 2 commits into from
Feb 12, 2024
Merged

[14.0] [FIX] stock_barcodes: restore read_inventory to old version #582

merged 2 commits into from
Feb 12, 2024

Conversation

renda-dev
Copy link

supersedes #569

Fixes #565 introduced by #560

also, added tests that would fail without the latest commit.

@francesco-ooops
Copy link
Contributor

@dalonsod good for you? :)

@dalonsod dalonsod mentioned this pull request Jan 31, 2024
Closed
@dalonsod
Copy link

@alexis-via this solves #565 could you review?

@francesco-ooops
Copy link
Contributor

@pedrobaeza @sergio-teruel this solves an issue introduced here: #560 (comment) , could you take a look? thanks!

@pedrobaeza
Copy link
Member

If others confirmed it's OK, we can merge, but we don't work in this version with this.

geomer198
geomer198 reviewed Feb 9, 2024
View reviewed changes
Copy link

@geomer198 geomer198 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@renda-dev renda-dev force-pushed the 14.0-fix-stock_barcode branch from aa4750b to 7023657 Compare February 12, 2024 08:59
@francesco-ooops
Copy link
Contributor

@pedrobaeza please proceed with merge, thanks!

@pedrobaeza pedrobaeza added this to the 14.0 milestone Feb 12, 2024
@pedrobaeza
Copy link
Member

/ocabot merge major

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-582-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 64863da into OCA:14.0 Feb 12, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at dc7a8df. Thanks a lot for contributing to OCA. ❤️

@renda-dev renda-dev deleted the 14.0-fix-stock_barcode branch February 12, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalonsod dalonsod dalonsod approved these changes

@geomer198 geomer198 geomer198 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
7 participants
@renda-dev @francesco-ooops @dalonsod @pedrobaeza @OCA-git-bot @geomer198 @ChristianSantamaria