[16.0][IMP] stock_barcodes #668

edescalona · 2024-12-25T20:39:49Z

@BinhexTeam The different views for the barcode have been modified.

rousseldenis · 2025-01-23T08:42:44Z

@edescalona As the changes in this are quite different than the PR description, could you enhance it to enumerate them?

And it is better to add the module name in the commit messages like [IMP] stock_barcodes: (...).

Thanks!

edescalona · 2025-01-23T13:26:19Z

@edescalona As the changes in this are quite different than the PR description, could you enhance it to enumerate them?

And it is better to add the module name in the commit messages like [IMP] stock_barcodes: (...).

Thanks!

Hello @rousseldenis , ok, I'll upload other improvements in a while and with their description, greetings

mrsavage · 2025-01-24T07:32:57Z

I really would like to have this :) Thanks for the work

edescalona · 2025-01-24T23:52:41Z

Hi @mrsavage @rousseldenis , the PR is ready to be reviewed again, any opinion is welcome, thanks.

Christian-RB · 2025-01-27T10:18:27Z

@edescalona Can you check the files changed? There are modules that shouldn't be envolved here

…tory and Operations scan views

edescalona · 2025-01-27T15:45:30Z

@edescalona Can you check the files changed? There are modules that shouldn't be envolved here

Hi @Christian-RB I have already checked and corrected the changes in other modules that should not be involved. Ready to be reviewed, thanks for your contribution.

hitrosol · 2025-01-28T06:05:34Z

Thanks for this PR.
I try this on runboat.

Set the Barcode Option Group of Picking IN options in the Receipts
Click the Picking IN, in the Barcode menu.
Click the x to process button.
It shows the Picking In orders.
Validate one of them.
The screen now show all picking order. IMHO it should only shows the same picking type order.

edescalona · 2025-01-29T13:02:44Z

Thanks for this PR. I try this on runboat.

Set the Barcode Option Group of Picking IN options in the Receipts

Click the Picking IN, in the Barcode menu.

Click the x to process button.

It shows the Picking In orders.

Validate one of them.

The screen now show all picking order. IMHO it should only shows the same picking type order.

Hello @hitrosol , thank you for your contribution. I will review the details you mentioned. Thank you very much.

…the one previously validated.

edescalona · 2025-01-29T15:14:58Z

Hello @hitrosol I have already made the change you suggested, thanks for your contribution, it can be reviewed again, greetings

baguenth

Your pull requests could have more code documentation from my point of view.
Currently there are only a few doc strings and code comments.

Especially when changing a lot of code (what you did) I highly recommend to document the code well. This helps reviewers to understand the changes.

stock_barcodes/models/stock_barcodes_action.py

baguenth · 2025-01-31T08:59:25Z

stock_barcodes/models/stock_barcodes_action.py

+        if len(matched_actions) > len(all_barcode):
+            raise ValidationError(
+                _(
+                    f"Barcode has already been assigned to "


Odoos translation engine (babel) doesn't support F-strings in the used version.
Please use format strings or something similar.

Your comment has been resolved, thank you for your contribution.

baguenth · 2025-01-31T09:00:33Z

stock_barcodes/models/stock_barcodes_action.py

+
+    @api.constrains("context")
+    def _constrains_context(self):
+        if self.context and not bool(


Odoos translation engine (babel) doesn't support F-strings in the used version.
Please use format strings or something similar.

Your comment has been resolved, thank you for your contribution.

baguenth · 2025-01-31T09:12:30Z

stock_barcodes/wizard/stock_barcodes_read_picking.py

@@ -396,7 +408,7 @@ def _prepare_stock_moves_domain(self):
        ]
        if self.picking_id:
            domain.append(("picking_id", "=", self.picking_id.id))
-        return domain
+        return []


This function statically returns [] now. I guess this is not correct.

Your comment has been resolved, thank you for your contribution.

edescalona · 2025-01-31T15:23:06Z

Hi @baguenth I've already reviewed your comments, thanks for your contribution

…omain

…}.format()

edescalona · 2025-01-31T16:35:19Z

Your pull requests could have more code documentation from my point of view. Currently there are only a few doc strings and code comments.

Especially when changing a lot of code (what you did) I highly recommend to document the code well. This helps reviewers to understand the changes.

Ok, I will add some other indications for better understanding, thanks

[16.0][IMP] stock_barcodes: Readme

edescalona · 2025-02-04T20:38:04Z

Hi @baguenth , I have already made improvements to the documentation. Please let me know when you can. Thanks for your contribution.

baguenth · 2025-02-06T10:20:52Z

stock_barcodes/models/stock_barcodes_action.py

+        for action in self:
+            if not re.match(REGEX.get("barcode", False), action.barcode):
+                raise ValidationError(
+                    _(


Tbh I am not sure if we can and should use the format part within the translation bracket. Better use:

_("...").format(...)

baguenth · 2025-02-06T10:27:17Z

stock_barcodes/models/stock_barcodes_action.py

+            matched_actions = self.sudo().search(domain, order="id")
+            if len(matched_actions) > len(all_barcode):
+                raise ValidationError(
+                    _(


Tbh I am not sure if we can and should use the format part within the translation bracket. Better use:

_("...").format(...)

edescalona · 2025-02-06T13:32:13Z

Hi @baguenth , you can now review the changes, thanks for your contribution.

edescalona closed this Dec 27, 2024

edescalona reopened this Jan 7, 2025

edescalona force-pushed the 16.0-imp-stock-barcodes-styles branch from 40a5fff to 8db115d Compare January 7, 2025 06:28

edescalona closed this Jan 7, 2025

edescalona reopened this Jan 7, 2025

edescalona force-pushed the 16.0-imp-stock-barcodes-styles branch from 5b174db to ebdc6c8 Compare January 21, 2025 04:08

edescalona mentioned this pull request Jan 21, 2025

Migration to version 17.0 #555

Open

7 tasks

edescalona force-pushed the 16.0-imp-stock-barcodes-styles branch from 626a984 to ddcf9f7 Compare January 23, 2025 02:39

edescalona force-pushed the 16.0-imp-stock-barcodes-styles branch from 15699bc to 3353c3a Compare January 23, 2025 18:14

edescalona force-pushed the 16.0-imp-stock-barcodes-styles branch 3 times, most recently from 03c8f1e to bbd2046 Compare January 24, 2025 23:50

[IMP] stock_barcodes: Visual and functional improvements to the Inven…

1559540

…tory and Operations scan views

edescalona force-pushed the 16.0-imp-stock-barcodes-styles branch from 597bc39 to 1559540 Compare January 27, 2025 15:37

edescalona added 2 commits January 29, 2025 09:35

[16.0][IMP] stock_barcodes: Showing the pickings of the same type as …

6e1fd93

…the one previously validated.

[16.0][IMP] stock_barcodes: Add tests.

cd8bc6d

[16.0][IMP] stock_barcodes: Changing ID of barcode main action

7244872

baguenth suggested changes Jan 31, 2025

View reviewed changes

edescalona added 2 commits January 31, 2025 10:50

[16.0][IMP] stock_barcodes: Add bucle for in constrains. Add return d…

b88a719

…omain

[16.0][IMP] stock_barcodes: Changing the format of f-strings (f) to {…

f1a1ba5

…}.format()

[16.0][FIX] stock_barcodes: Validating existing method

f8b88ec

[16.0][IMP] stock_barcodes: Readme

2bd5dcc

[16.0][IMP] stock_barcodes: Readme

baguenth suggested changes Feb 6, 2025

View reviewed changes

[16.0][IMP] stock_barcodes: Change format string

a9fb278

baguenth approved these changes Feb 6, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][IMP] stock_barcodes #668

[16.0][IMP] stock_barcodes #668

edescalona commented Dec 25, 2024 •

edited

Loading

rousseldenis commented Jan 23, 2025

edescalona commented Jan 23, 2025

mrsavage commented Jan 24, 2025 •

edited

Loading

edescalona commented Jan 24, 2025

Christian-RB commented Jan 27, 2025

edescalona commented Jan 27, 2025

hitrosol commented Jan 28, 2025

edescalona commented Jan 29, 2025

edescalona commented Jan 29, 2025

baguenth left a comment

baguenth Jan 31, 2025

edescalona Jan 31, 2025

baguenth Jan 31, 2025

edescalona Jan 31, 2025

baguenth Jan 31, 2025

edescalona Jan 31, 2025

edescalona commented Jan 31, 2025

edescalona commented Jan 31, 2025

edescalona commented Feb 4, 2025

baguenth Feb 6, 2025

baguenth Feb 6, 2025

edescalona commented Feb 6, 2025

[16.0][IMP] stock_barcodes #668

Are you sure you want to change the base?

[16.0][IMP] stock_barcodes #668

Conversation

edescalona commented Dec 25, 2024 • edited Loading

rousseldenis commented Jan 23, 2025

edescalona commented Jan 23, 2025

mrsavage commented Jan 24, 2025 • edited Loading

edescalona commented Jan 24, 2025

Christian-RB commented Jan 27, 2025

edescalona commented Jan 27, 2025

hitrosol commented Jan 28, 2025

edescalona commented Jan 29, 2025

edescalona commented Jan 29, 2025

baguenth left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edescalona commented Jan 31, 2025

edescalona commented Jan 31, 2025

edescalona commented Feb 4, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

edescalona commented Feb 6, 2025

edescalona commented Dec 25, 2024 •

edited

Loading

mrsavage commented Jan 24, 2025 •

edited

Loading