[IMP] add data product uom week. #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yweng8111 Can you please improve the test coverage? |
|
@yweng8111 Do you know what's the problem of the pre-commit? How can we fix it? Version 3.9.7 was not found in the local cache Error: Version 3.9.7 with arch x[6](https://github.com/OCA/vertical-rental/actions/runs/3702369286/jobs/6272568713#step:3:7)4 not found The list of all available versions can be found here: https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json |
|
@yweng8111 Can you check this please? |
|
Can we just update the python version in the pre-commit workflow from 3.9.7 to 3.9.18 please? |
yweng8111
force-pushed
the
12.0-rental_base_uom_week
branch
from
5cf74bf to
b0252a4
Compare
yweng8111
force-pushed
the
12.0-rental_base_uom_week
branch
from
b0252a4 to
03c0bd7
Compare
|
@chandni299 Please remind me: What is this useful for? I still can just create rental orders with uom hours, days or months - but not weeks. It's a while ago that I tested rental orders... ^^ |
|
Hello @marylla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.