Floodscan backfilling #66
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the
--backfillargument for the Floodscan pipeline. Have added in some minor refactoring to address bugs and improve legibility of some functions. The majority of changes are in the_get_90_days_filenames_for_datesfunction, which I've rewritten. I've also refactored theself.run_pipelinemethod so that it accepts a list of generic dates as input and runs updates accordingly.I've also suggested removing some of the general
try/exceptblocks, as I found that during development these were quite challenging to debug (eg. a lot of error messages were the same) and could hide a lot of errors happening.The
floodscan_testing.mdnotebook is a helpful walkthrough to validate these changes -- please run through and let me know if any errors.