New 3W data and remove phonetic matching #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make phonetic matching optional
HDXDSYS-866 update ner and sdn 3w
|
@alexandru-m-g shoot the tests are now failing due to a breaking change in the hdx python libraries. I'll need to fix that Monday. |
* Use normalise function from HDX Python Utilities * 3 letter names not matched now because we set a minimum length of 4, so add mappings Fix name replacements * Update CHANGELOG
|
Tests are now be fixed by Mike's changes. If the export runs properly then it should be good to go. |
Pull Request Test Coverage Report for Build 9803423821Details
💛 - Coveralls |
alexandru-m-g
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are: