Work on DatabaseConnector 7 issues

[ablack3]

https://github.com/OHDSI/DatabaseConnector/milestone/7

[schuemie]

Hi @ablack3 . Thanks for all your hard work on this! What is the status? Do you think this PR is ready for full review?

[ablack3]

I think it's ready. There is a long tail of small issues that are time consuming to fix. Today we were working on copy_to which is not working on Oracle because the Analyze statement that runs after insertTable doesn't know about temp emulation. But I think the impact of that is quite low and it's better to move forward. I want to see if Cran accepts the approach we're using to import dbplyr's private functions.

I'm also hesitant to remove the depreciated database systems. I know Netezza is still being used which should be nearly the same as Postgres SQL.

Will you start your review @schuemie?

We will get GitHub actions passing.

[ablack3]

@schuemie, what do you think about moving rJava to suggests and making it an optional dependency in DatabaseConnector? In the UK there are environments where only R (CRAN) and python are allowed and Java is not.

[schuemie]

I guess I'm ok with moving rJava to Suggests. There's noting intrinsic to DatabaseConnector that requires it, just some (currently most) of the drivers.

[schuemie]

On the deprecated platforms: our policy states we try to leave the code, but will not accept issues or PRs related to those. So if we can leave the code without work we should, but if any effort is required we can drop them.

[codecov]

Codecov Report

Attention: Patch coverage is 94.36620% with 4 lines in your changes missing coverage. Please review.

Project coverage is 59.46%. Comparing base (24ce059) to head (e0e4a2b).
Report is 6 commits behind head on develop.

Files with missing lines	Patch %	Lines
R/DBI.R	84.61%	2 Missing ⚠️
R/backend-DatabaseConnector.R	95.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #305      +/-   ##
===========================================
+ Coverage    57.46%   59.46%   +2.00%     
===========================================
  Files           15       15              
  Lines         2969     2780     -189     
===========================================
- Hits          1706     1653      -53     
+ Misses        1263     1127     -136     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.