fix merging mistake

OHDSI · Dec 22, 2023 · a52d831 · a52d831
1 parent 07dd58a
commit a52d831
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/R/Estimator.R b/R/Estimator.R
@@ -402,7 +402,7 @@ gridCvDeep <- function(mappedData,
   }
 
   modelParams$catFeatures <- dataset$get_cat_features()$max()
-  modelParams$numFeatures <- dataset$get_numerical_features()$max()
+  modelParams$numFeatures <- dataset$get_numerical_features()$len()
 
   estimatorSettings <- fillEstimatorSettings(modelSettings$estimatorSettings,
                                              fitParams,

diff --git a/tests/testthat/test-Estimator.R b/tests/testthat/test-Estimator.R
@@ -1,5 +1,5 @@
 catFeatures <- smallDataset$dataset$get_cat_features()$max()
-numFeatures <- smallDataset$dataset$get_numerical_features()$max()
+numFeatures <- smallDataset$dataset$get_numerical_features()$len()
 
 modelParameters <- list(
   cat_features = catFeatures,

diff --git a/tests/testthat/test-LRFinder.R b/tests/testthat/test-LRFinder.R
@@ -64,8 +64,8 @@ test_that("LR finder works with device specified by a function", {
     model = "ResNet",
     modelParameters =
       list(cat_features = dataset$get_cat_features()$max(),
-           num_features = dataset$get_numerical_features()$max(),
-          size_embedding = 8L,
+           num_features = dataset$get_numerical_features()$len(),
+           size_embedding = 8L,
            size_hidden = 16L,
            num_layers = 1L,
            hidden_factor = 1L),