Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temporalModel attribute to models that support it #137

Open
egillax opened this issue Jan 21, 2025 · 0 comments
Open

Add temporalModel attribute to models that support it #137

egillax opened this issue Jan 21, 2025 · 0 comments

Comments

@egillax
Copy link
Collaborator

egillax commented Jan 21, 2025

In plp there is now a check in checkInputs to stop people from trying to use temporal data on models that don't support it:

  if (FeatureExtraction::isTemporalCovariateData(inputs$plpData$covariateData)
      && (is.null(attr(inputs$modelSettings$param, "temporalModel")))) {
    stop("Temporal covariates detected but chosen model does not support temporal covariates")
  }

This means when we add models that support it here we need to add the temporalModel attribute to modelSettings$param

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant