lua: convert ssh function into suricata.ssh lib #12954
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7607
jasonish
reviewed
Apr 5, 2025
Comment on lines
+23
to
+24
| the available SSH buffers listed in :ref:`lua-detection` and follow | ||
| the pattern: |
There was a problem hiding this comment.
Is this list of buffers up to date and insync with whats documented below?
There was a problem hiding this comment.
ok in next version
jasonish
reviewed
Apr 5, 2025
doc/userguide/lua/libs/ssh.rst
Outdated
Comment on lines
71
to
72
| ``server_software()`` | ||
| ^^^^^^^^^^^^^^^^^^ |
There was a problem hiding this comment.
As CI shows, the underlines here aren't long enough.
|
Only a quick review so far, but the API on the Lua side looks OK. |
|
Need some doc improvements |
|
Information: QA ran without warnings. Pipeline 25559 |
|
WARNING:
Pipeline 25562 |
|
Next in #13013 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7607
Describe changes:
SV_BRANCH=OISF/suricata-verify#2420