rust: fixups for publishing to crates.io - v3 #13005
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a normal project where the Cargo.lock is checked in, it would be normal to see an updated Cargo.lock in git status and the like. As we use autoconf to generate this file, we should just copy it back to the input file so we get the same convenience of seeing when it is updated, which usually means it needs to be checked in. However, to satisfy "make distcheck", only copy it if the input template exists, if the input template does not exist we are in an out of tree build.
For publishing to crates.io.
As the "suricata" crate depends on htp, we need to publish htp to crates.io first, however "htp" name is already taken. So rename "htp" to "suricata-htp".
Remove the authors field as it is deprecated. Update the repository page to the Suricata repository. Remove the homepage, it can be found via the reposistory page.
victorjulien
approved these changes
Apr 11, 2025
Merged
|
Merged in #13016, thanks! |
|
Thanks Jason, it works catenacyber/suricata-zabbix@cbcab95 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version updates the Cargo.lock.
Additionally, always update the Cargo.lock.in to keep it in sync with
Cargo.lock. This will always make us aware when it has changed and needs to be
committed.