Websocket compression 7285 v3 #13018
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ticket: 7285 Previously, only messages over multiple PDUs could get decompressed
move flate2.rs to a backend supporting the setting of window_bits, which is not the case for miniz-oxide. This will allow WebSocket to use Sec-WebSocket-Extensions which can set a non-default window_bits
catenacyber
requested review from
jasonish,
victorjulien and
a team
as code owners
catenacyber
force-pushed
the
websocket-compression-7285-v3
branch
from
226f339 to
8716c4e
Compare
|
WARNING:
Pipeline 25689 |
Ticket: 7285 As this is the default for websocket, which is bigger than the defaut for zlib usage Also limit the decompressed content to the max-payload-size configuration parameter also used for non-compressed content. And also use a stateful decoder to store/remember the compression state to be able to decompress later messages.
Optimization to avoid consuming too much memory for decompression
catenacyber
force-pushed
the
websocket-compression-7285-v3
branch
from
8716c4e to
b953162
Compare
|
WARNING:
Pipeline 25690 |
|
Information: QA ran without warnings. Pipeline 25691 |
|
Clean in #13022 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7285
Describe changes:
Sec-WebSocket-Extensions: permessage-deflate; client_max_window_bits=15, especially themax_window_bits=15for the decompressorSV_BRANCH=OISF/suricata-verify#2387
#12930 rebased and more detailed commit history
I am not sure we need and want the last commit (too much complexity for some small optimization)