Skip to content

Http1 brotli 5692 v2 #13025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

Http1 brotli 5692 v2 #13025

wants to merge 4 commits into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/5692

Describe changes:

  • http1: support brotli decompression

SV_BRANCH=OISF/suricata-verify#2441

#13014 with a new commit to keep code coverage profraw smaller and CI green for suricata verify codecov

Looks like zstd is another algorithm we miss cf https://developer.mozilla.org/en-US/docs/Web/HTTP/Reference/Headers/Content-Encoding

@catenacyber
http1: brotli decompression
142f45d 
Ticket: 5692

http2 already used brotli crate for decompression
@catenacyber
ci: rustc wrapper to disable coverage for external crates
fbbbc4f 
To keep the disk usage good even when we use new crates
@catenacyber catenacyber requested review from jasonish and a team as code owners April 15, 2025 14:42
@catenacyber catenacyber mentioned this pull request Apr 15, 2025
Closed
@catenacyber catenacyber marked this pull request as draft April 15, 2025 14:51
@catenacyber catenacyber mentioned this pull request Apr 15, 2025
Merged
@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 25706

@jasonish
Copy link
Member

Any idea how much disk space this saves? Or will it just a short term band-aid?

@catenacyber
Copy link
Contributor Author

catenacyber commented Apr 16, 2025 •
edited
Loading

Any idea how much disk space this saves? Or will it just a short term band-aid?

Profraw files go from 4.2M to 1.7M each locally.
(enabling external crates but not suricata, I get 2.3M)

Do you want me to test CI ?

@catenacyber catenacyber mentioned this pull request Apr 16, 2025
Closed
@catenacyber
Copy link
Contributor Author

Clean in #13031

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonish jasonish Awaiting requested review from jasonish jasonish is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@catenacyber @suricata-qa @jasonish