Nixos support v1.1 #13070
Open
Nixos support v1.1 #13070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13070 +/- ##
==========================================
- Coverage 82.79% 82.78% -0.01%
==========================================
Files 984 984
Lines 272712 272712
==========================================
- Hits 225782 225764 -18
- Misses 46930 46948 +18
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
regit
force-pushed
the
nixos-support-v1.1
branch
3 times, most recently
from
c613c66 to
e3bdfb2
Compare
|
Good for review. |
jasonish
reviewed
Apr 22, 2025
regit
force-pushed
the
nixos-support-v1.1
branch
from
e3bdfb2 to
9f588f8
Compare
By adding a `shell.nix` file in the root directory of the source, NixOs (https://nixos.org/) users can get a ready for development environment by simply running `nix-shell` from the source tree. This is really convenient as the installation of needed packages is just done as user and transparently for the user/developer. Ticket: 7669
This can be used from command line to add some build options without running a full configure. This is convenient for single run build.
It generates a `compile_commands.json` suitable for clangd. This is almost mandatory to have a command like this one for NixOs users as tool like bear are not able to intercept correctly the clang calls due to the usage of a wrapper. Ticket: 7669
regit
force-pushed
the
nixos-support-v1.1
branch
2 times, most recently
from
edaed3c to
1c72d0c
Compare
This will test that shell.nix is working properly and also test compile-commands Makefile target.
regit
force-pushed
the
nixos-support-v1.1
branch
from
1c72d0c to
7876471
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update of #13063
Contribution style:
https://docs.suricata.io/en/latest/devguide/contributing/contribution-process.html
Our Contribution agreements:
https://suricata.io/about/contribution-agreement/ (note: this is only required once)
Changes (if applicable):
(including schema descriptions)
https://redmine.openinfosecfoundation.org/projects/suricata/issues
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7669
Describe changes: