Skip to content

detect/vlan: fix leak with bad signature #13321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
None, found in #13319

Describe changes:

  • detect/vlan: fix leak with bad signature

@catenacyber catenacyber requested a review from victorjulien as a code owner May 27, 2025 13:17
Copy link
Member

@inashivb inashivb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! LGTM 🚀

@victorjulien victorjulien added this to the 8.0 milestone May 27, 2025
Copy link

codecov bot commented May 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (b4095bf) to head (a493f13).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13321      +/-   ##
==========================================
+ Coverage   83.41%   83.43%   +0.02%     
==========================================
  Files         995      995              
  Lines      272813   272814       +1     
==========================================
+ Hits       227558   227621      +63     
+ Misses      45255    45193      -62     
Flag Coverage Δ
fuzzcorpus 62.09% <100.00%> (+0.05%) ⬆️
livemode 18.94% <0.00%> (-0.01%) ⬇️
pcap 44.90% <0.00%> (-0.02%) ⬇️
suricata-verify 65.00% <0.00%> (+0.01%) ⬆️
unittests 59.25% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline 26252

@victorjulien
Copy link
Member

Merged in #13328, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants