Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WellKnownRole_Anonymous and WellKnownRole_AuthenticatedUser RoleState instances have the method states uninitialized. #3006

Open
1 of 5 tasks
mrsuciu opened this issue Feb 19, 2025 · 3 comments
Assignees

Comments

@mrsuciu
Copy link
Contributor

mrsuciu commented Feb 19, 2025

Type of issue

  • Bug
  • Enhancement
  • Compliance
  • Question
  • Help wanted

Current Behavior

Reproduced on the PR 2893
The WellKnownRole_Anonymous and WellKnownRole_AuthenticatedUser RoleState instances have the AddIdentity, AddApplication,
AddEndpoint, RemoveIdentity, RemoveApplication, RemoveEndpoint method states uninitialized, while all the other WellKnownRole_ RoleState instances have them initialized.

Expected Behavior

WellKnownRole_Anonymous and WellKnownRole_AuthenticatedUser RoleState instances should be also correctly instantiated as the rest of the WellKnownRole_ RoleState are.

Steps To Reproduce

Inspenct roleState:

RoleState roleState = FindNodeInAddressSpace(roleNodeId) as RoleState; // Where roleNodeId is ObjectIds.WellKnownRole_Anonymous or // ObjectIds.WellKnownRole_AuthenticatedUser

Environment

[PR 2893](https://github.com/OPCFoundation/UA-.NETStandard/pull/2893)

Anything else?

No response

@opcfoundation-org
Copy link
Contributor

There were updated and the Optional Methods were omitted.
Omitting optional methods reduces the size of the NodeSet.
Not sure if the right fix removes all optional methods or added them in for all.

@mrsuciu
Copy link
Contributor Author

mrsuciu commented Feb 20, 2025

There were updated and the Optional Methods were omitted. Omitting optional methods reduces the size of the NodeSet. Not sure if the right fix removes all optional methods or added them in for all.

I would include them for all since the rest all have them and there might be existing code that already assumes that they are included.

@mrsuciu
Copy link
Contributor Author

mrsuciu commented Feb 20, 2025

ObjectIds.WellKnownRole_TrustedApplication is in the same situation.
Besides the method states also property states such as PropertyState<string[]> Applications for the above mentioned RoleState instances are not initialized while for the rest they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants