Wrong error thrown "BadTooManyArguments" instead of "BadNotImplemented"

[raserle]

Type of issue

• Bug
• Enhancement
• Compliance
• Question
• Help wanted

Current Behavior

@romanett
In Bug you see the error "BadTooManyArguments" on call the method.
If you have a "NodeManager:CustomNodeManager2" with Call method

and call the base

you end in MethodState

and on line 653 is the return. That is what happen wenn no method implemented.

The correct check what we need, comes in this call.

That is a test for implementation of method, and this could return NotImplemented. But with the checks before we never reach this.

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- Environment:
- Runtime:
- Nuget Version:
- Component:
- Server:
- Client:

Anything else?

No response

[romanett]

@raserle Thanks for bringing this up
MethodState is initialized with (User)Exectuable true.
And I don`t think we can change it without breaking existing implementations.
So not shure if this StatusCode would ever be thrown, even if we put the check before the input arguments validation.

[raserle]

Thats the body of the second Call Method, that get called after check input/output params

GenericMethodCalledEventHandler2 onCallMethod2 = OnCallMethod2;
if (onCallMethod2 != null)
{
    return onCallMethod2(context, this, objectId, inputArguments, outputArguments);
}
GenericMethodCalledEventHandler onCallMethod = this.OnCallMethod;
if (onCallMethod != null)
{
    return onCallMethod(context, this, inputArguments, outputArguments);
}
if (Executable && UserExecutable)
{
    return StatusCodes.BadNotImplemented;
}
return StatusCodes.BadUserAccessDenied;

Is it possible to test, before run argument tests?

GenericMethodCalledEventHandler2 onCallMethod2 = OnCallMethod2;
GenericMethodCalledEventHandler onCallMethod = this.OnCallMethod;

if (onCallMethod2 == null && onCallMethod == null) return NotImplemented....