OpenFileGDB: add 'gdal driver openfilegdb repack'

Author: rouault

autotest/ogr/ogr_openfilegdb_write.py

@@ -4601,3 +4601,45 @@ def test_ogr_openfilegdb_write_check_golden_file(tmp_path, src_directory):
         assert (
             open(src_filename, "rb").read() == open(out_filename, "rb").read()
         ), filename
+
+
+###############################################################################
+# Test 'gdal driver openfilegdb repack'
+
+
+@gdaltest.enable_exceptions()
+def test_ogropenfilegdb_write_gdal_driver_openfilegdb_repack(tmp_path):
+
+    alg = gdal.GetGlobalAlgorithmRegistry()["driver"]
+    assert alg.GetName() == "driver"
+
+    alg = gdal.GetGlobalAlgorithmRegistry()["driver"]["openfilegdb"]
+    assert alg.GetName() == "openfilegdb"
+
+    out_directory = str(tmp_path / "test.gdb")
+    gdal.VectorTranslate(
+        out_directory, "data/openfilegdb/polygon_golden.gdb", format="OpenFileGDB"
+    )
+
+    alg = gdal.GetGlobalAlgorithmRegistry()["driver"]["openfilegdb"]["repack"]
+    assert alg.GetName() == "repack"
+    alg["input"] = "data/poly.shp"
+    with pytest.raises(Exception, match="is not a FileGeoDatabase"):
+        alg.Run()
+
+    alg = gdal.GetGlobalAlgorithmRegistry()["driver"]["openfilegdb"]["repack"]
+    assert alg.GetName() == "repack"
+    alg["input"] = out_directory
+    assert alg.Run()
+
+    last_pct = [0]
+
+    def my_progress(pct, msg, user_data):
+        last_pct[0] = pct
+        return True
+
+    alg = gdal.GetGlobalAlgorithmRegistry()["driver"]["openfilegdb"]["repack"]
+    assert alg.GetName() == "repack"
+    alg["input"] = out_directory
+    assert alg.Run(my_progress)
+    assert last_pct[0] == 1.0

ogr/ogrsf_frmts/openfilegdb/ogr_openfilegdb.h

@@ -519,6 +519,11 @@ class OGROpenFileGDBDataSource final : public GDALDataset
 
     virtual CPLErr FlushCache(bool bAtClosing = false) override;
 
+    std::vector<std::unique_ptr<OGROpenFileGDBLayer>> &GetLayers()
+    {
+        return m_apoLayers;
+    }
+
     virtual int GetLayerCount() override
     {
         return static_cast<int>(m_apoLayers.size());

ogr/ogrsf_frmts/openfilegdb/ogropenfilegdbdriver.cpp

@@ -21,6 +21,7 @@
 #include "cpl_vsi.h"
 #include "gdal.h"
 #include "gdal_priv.h"
+#include "gdalalgorithm.h"
 #include "ogr_core.h"
 
 // g++ -O2 -Wall -Wextra -g -shared -fPIC ogr/ogrsf_frmts/openfilegdb/*.cpp
@@ -149,6 +150,77 @@ static CPLErr OGROpenFileGDBDriverDelete(const char *pszFilename)
     return CE_None;
 }
 
+/************************************************************************/
+/*                    OpenFileGDBRepackAlgorithm                        */
+/************************************************************************/
+
+class OpenFileGDBRepackAlgorithm final : public GDALAlgorithm
+{
+  public:
+    OpenFileGDBRepackAlgorithm()
+        : GDALAlgorithm("repack", std::string("Repack a FileGDB dataset"),
+                        "/drivers/vector/openfilegdb.html")
+    {
+        AddProgressArg();
+        AddInputDatasetArg(&m_dataset,
+                           GDAL_OF_RASTER | GDAL_OF_VECTOR | GDAL_OF_UPDATE);
+    }
+
+  protected:
+    bool RunImpl(GDALProgressFunc pfnProgress, void *pProgressData) override
+    {
+        auto poDS =
+            dynamic_cast<OGROpenFileGDBDataSource *>(m_dataset.GetDatasetRef());
+        if (!poDS)
+        {
+            ReportError(CE_Failure, CPLE_AppDefined,
+                        "%s is not a FileGeoDatabase",
+                        m_dataset.GetName().c_str());
+            return false;
+        }
+        bool bSuccess = true;
+        int iLayer = 0;
+        for (auto &poLayer : poDS->GetLayers())
+        {
+            void *pScaledData = GDALCreateScaledProgress(
+                static_cast<double>(iLayer) / poDS->GetLayerCount(),
+                static_cast<double>(iLayer + 1) / poDS->GetLayerCount(),
+                pfnProgress, pProgressData);
+            const bool bRet = poLayer->Repack(
+                pScaledData ? GDALScaledProgress : nullptr, pScaledData);
+            GDALDestroyScaledProgress(pScaledData);
+            if (!bRet)
+            {
+                ReportError(CE_Failure, CPLE_AppDefined,
+                            "Repack of layer %s failed", poLayer->GetName());
+                bSuccess = false;
+            }
+            ++iLayer;
+        }
+        return bSuccess;
+    }
+
+  private:
+    GDALArgDatasetValue m_dataset{};
+};
+
+/************************************************************************/
+/*                 OGROpenFileGDBInstantiateAlgorithm()                 */
+/************************************************************************/
+
+static GDALAlgorithm *
+OGROpenFileGDBInstantiateAlgorithm(const std::vector<std::string> &aosPath)
+{
+    if (aosPath.size() == 1 && aosPath[0] == "repack")
+    {
+        return std::make_unique<OpenFileGDBRepackAlgorithm>().release();
+    }
+    else
+    {
+        return nullptr;
+    }
+}
+
 /***********************************************************************/
 /*                       RegisterOGROpenFileGDB()                      */
 /***********************************************************************/
@@ -168,6 +240,7 @@ void RegisterOGROpenFileGDB()
     poDriver->pfnOpen = OGROpenFileGDBDriverOpen;
     poDriver->pfnCreate = OGROpenFileGDBDriverCreate;
     poDriver->pfnDelete = OGROpenFileGDBDriverDelete;
+    poDriver->pfnInstantiateAlgorithm = OGROpenFileGDBInstantiateAlgorithm;
 
     GetGDALDriverManager()->RegisterDriver(poDriver);
 }

ogr/ogrsf_frmts/openfilegdb/ogropenfilegdbdrivercore.cpp

@@ -306,6 +306,8 @@ void OGROpenFileGDBDriverSetCommonMetadata(GDALDriver *poDriver)
     poDriver->pfnIdentify = OGROpenFileGDBDriverIdentify;
     poDriver->SetMetadataItem(GDAL_DCAP_OPEN, "YES");
     poDriver->SetMetadataItem(GDAL_DCAP_CREATE, "YES");
+
+    poDriver->DeclareAlgorithm({"repack"});
 }
 
 /************************************************************************/