MiraMonVector: fix a case of mutirecord (lists) in some fields

[AbelPau]

What does this PR do?

Fixes a found error writing a MiraMon vector from a JSON file. This JSON file contains some lists in some fields (not the first ones).
There was a memory allocation error due to an error in initializing the number of fields of the second MiraMon record.

The file:
LT05_L2SP_038037_20120505_20200820_02_T1_ST_stac_minimal.json

Tasklist

• Make sure code is correctly formatted (cf pre-commit configuration)
• Add a test case to prove the fix
• All CI builds and checks have passed

[rouault]

It could be valuable to have a autotest check demonstrating the fix

[AbelPau]

It could be valuable to have a autotest check demonstrating the fix

Yes, I'm preparing it but it take a lot of time (due to docker, windows instead of linux and this kind of things). Meanwhile I was preparing the draft to have some work done.

Tomorrow I'll have prepared! Thanks.

[AbelPau]

It could be valuable to have a autotest check demonstrating the fix

Where is the appropiate place to leave the "problematic" JSON file?
"autotest\ogr\data\jsonfg" or "autotest\ogr\data\miramon\reading_test"

thanks!

[rouault]

"autotest\ogr\data\miramon\reading_test"

more that one. But do you actually need a test file? Can't that be reproduced by using CreateFeature() directly with the appropriate field definition and feature values ?

[AbelPau]

"autotest\ogr\data\miramon\reading_test"

more that one. But do you actually need a test file? Can't that be reproduced by using CreateFeature() directly with the appropriate field definition and feature values ?

It's a very short file (21 kb) and has like 20 fields, some of the with lists. Not complicated to create but more reliable to check from the original file (that has caused the problem) than a created one.

But if you think it's better I can try to create it.

[rouault]

Or try to really minimize the input dataset to the minimum that is actually needed. While 21 kb doesn't sound large, if for every bugfix in the > 250 drivers we have we would do that, that would amount to something huge.

[AbelPau]

Or try to really minimize the input dataset to the minimum that is actually needed. While 21 kb doesn't sound large, if for every bugfix in the > 250 drivers we have we would do that, that would amount to something huge.

Sure, I can eliminate all not necessary fields to reproduce the error and then use that. Let me try!

[AbelPau]

Or try to really minimize the input dataset to the minimum that is actually needed. While 21 kb doesn't sound large, if for every bugfix in the > 250 drivers we have we would do that, that would amount to something huge.

Sure, I can eliminate all not necessary fields to reproduce the error and then use that. Let me try!

LT05_L2SP_038037_20120505_20200820_02_T1_ST_stac_minimal.json

Here it is: 3 Kb (7 times less). I deleted unnecessary assets and other...

[coveralls]

coverage: 69.422% (+0.001%) from 69.421%
when pulling b73b846 on AbelPau:MiraMonVector-fix-stringlist,-integerlist,--case
into b4a3fde on OSGeo:master.

[rouault]

The backport to release/3.10 failed:

The process '/usr/bin/git' failed with exit code 128

stderr

error: commit fde7c6c25d13fbb40bd732a10ecc168f43375064 is a merge but no -m option was given.
fatal: cherry-pick failed

stdout

[backport-11148-to-release/3.10 89a3ecd34d] MiraMonVector: fix a case of mutirecord (lists) in some fields
 Author: AbelPau <a.pau@creaf.uab.cat>
 Date: Mon Oct 28 17:06:41 2024 +0100
 3 files changed, 160 insertions(+), 4 deletions(-)
 create mode 100644 autotest/ogr/data/miramon/reading_test/LT05_L2SP_038037_20120505_20200820_02_T1_ST_stac_minimal.json

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.10 release/3.10
# Navigate to the new working tree
cd .worktrees/backport-release/3.10
# Create a new branch
git switch --create backport-11148-to-release/3.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 6ea915861e5975b0b6b2d50c375c1fa94921f2d6,fde7c6c25d13fbb40bd732a10ecc168f43375064,b73b846c1bdb6b199d1e80436a7715bc56d18598
# Push it to GitHub
git push --set-upstream origin backport-11148-to-release/3.10
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.10

Then, create a pull request where the base branch is release/3.10 and the compare/head branch is backport-11148-to-release/3.10.

[AbelPau]

It seems there is a problem: D:\GitHub-repository\gdal>git worktree add .worktrees/backport-release/3.10 release/3.10 Preparing worktree (new branch 'release/3.10') branch 'release/3.10' set up to track 'upstream/release/3.10'. fatal: cannot create directory at 'autotest/gdrivers/data/sentinel2/fake_l1c_processing_baseline_5_09/S2B_MSIL1C_20230823T095559_N0509_R122_T34UCF_20230823T120234.SAFE/DATASTRIP/DS_2BPS_20230823T120234_S20230823T095553/QI_DATA': Filename too long Remember I am using Windows :( De: Even Rouault ***@***.***> Enviado el: dimecres, 30 d’octubre de 2024 12:04 Para: OSGeo/gdal ***@***.***> CC: Abel Pau ***@***.***>; Author ***@***.***> Asunto: Re: [OSGeo/gdal] MiraMonVector: fix a case of mutirecord (lists) in some fields (PR #11148) The backport to release/3.10 failed: The process '/usr/bin/git' failed with exit code 128 stderr error: commit fde7c6c is a merge but no -m option was given. fatal: cherry-pick failed stdout [backport-11148-to-release/3.10 89a3ecd34d] MiraMonVector: fix a case of mutirecord (lists) in some fields Author: AbelPau ***@***.******@***.***>> Date: Mon Oct 28 17:06:41 2024 +0100 3 files changed, 160 insertions(+), 4 deletions(-) create mode 100644 autotest/ogr/data/miramon/reading_test/LT05_L2SP_038037_20120505_20200820_02_T1_ST_stac_minimal.json To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-release/3.10 release/3.10 # Navigate to the new working tree cd .worktrees/backport-release/3.10 # Create a new branch git switch --create backport-11148-to-release/3.10 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick 6ea9158,fde7c6c25d13fbb40bd732a10ecc168f43375064,b73b846c1bdb6b199d1e80436a7715bc56d18598 # Push it to GitHub git push --set-upstream origin backport-11148-to-release/3.10 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-release/3.10 Then, create a pull request where the base branch is release/3.10 and the compare/head branch is backport-11148-to-release/3.10. — Reply to this email directly, view it on GitHub<#11148 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWDNBTBVAK7SH6WPN4ER3WTZ6C4LZAVCNFSM6AAAAABQXZO6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWGYYTKNRXGQ>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[rouault]

Remember I am using Windows :(

ah, perhaps you need to a shorted name, so maybe something like
git worktree add .worktrees/bkptr310 release/3.10

But nevermind for that backport. I'll manually cherry-pick since I want to issue a RC2 soon

[rouault]

cherry-picked in release/3.10 per commit c373931

[AbelPau]

Ok, I do nothing. It’s not an important error because I found it in a casual way. Not a required one. Thanks! De: Even Rouault ***@***.***> Enviado el: dimecres, 30 d’octubre de 2024 12:26 Para: OSGeo/gdal ***@***.***> CC: Abel Pau ***@***.***>; Author ***@***.***> Asunto: Re: [OSGeo/gdal] MiraMonVector: fix a case of mutirecord (lists) in some fields (PR #11148) Remember I am using Windows :( ah, perhaps you need to a shorted name, so maybe something like git worktree add .worktrees/bkptr310 release/3.10 But nevermind for that backport. I'll manually cherry-pick since I want to issue a RC2 soon — Reply to this email directly, view it on GitHub<#11148 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWDNBTFFZSPICLDQXXI5TDLZ6C65HAVCNFSM6AAAAABQXZO6EGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBWG4YDONRZGA>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>