gdal_translate: expand output to include pixels partially within -projwin #12105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looks good to me! |
dbaston
force-pushed
the
translate-projwin-expand
branch
from
af2c4c3 to
0c3cf66
Compare
dbaston
force-pushed
the
translate-projwin-expand
branch
2 times, most recently
from
35e8ea8 to
3c41908
Compare
dbaston
force-pushed
the
translate-projwin-expand
branch
from
73f081e to
ca3ae9b
Compare
|
In the end I needed to update expected results for tests in the VRT, WCS, ESRIC, and OGCAPI drivers. I'm not super-comfortable with the 50k-line diff in the OGCAPI tests, but 🤷♂️ |
rouault
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
gdal_translaterounds-projwinto the nearest pixels to avoid a grid shift. This may result in an output dataset that does not fully cover-projwin. This can be confusing, particularly when-projwinis specified in a different CRS from the source dataset. This PR modifies this behavior such that the output extent always includes-projwin.This breaks several driver tests. I can fix those if the change is conceptually OK.