-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Add a mechanism to register external algorithm, in particular for drivers #12126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7a49c59
to
c4d80c0
Compare
114588f
to
d837304
Compare
d837304
to
6f8935c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
This paves the road to useful driver-specific sub commands.
std::vector<std::string> ret = m_subAlgRegistry.GetNames(); | ||
const auto other = GDALGlobalAlgorithmRegistry::GetSingleton() | ||
.GetDeclaredSubAlgorithmNames(m_callPath); | ||
ret.insert(ret.end(), other.begin(), other.end()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we skip this insert call if other.empty()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we skip this insert call if
other.empty()
?
we could, but this adds extra code, for little advantage. This isn't a specially performance critical code path, and the overhead of inserting nothing should be un-noticeable
Fixes #12101