lib/gis: add support for PCRE #5159
Merged
+315
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Huidae Cho <grass4u@gmail.com> Co-authored-by: Nicklas Larsson <n_larsson@yahoo.com>
|
Rashad was the original author, wasn't he? |
|
We are not testing this in the CI with the assumption that the code will be eventually tested with CMake on Windows, right? Also, I think it does not need to go in before #3621. |
I tested it locally, configure and build, at least.
Not necessarily, I'll only remove the code changes there. The rest can stay. Probably easier than rebase/merge main on THAT one :-). |
I think so. |
HuidaeCho
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for PCRE, where/when GNU Regex cannot be used.
As this is mainly (perhaps only) needed on Win systems,
--without-pcreis default. If both Regex and PCRE are available on the system, Regex is used by default.