Optimize to_string() for power of two bases (#75)

OTheDev · Feb 3, 2025 · 5e96c4e · 5e96c4e
1 parent d155901
commit 5e96c4e
Show file tree

Hide file tree

Showing 15 changed files with 758 additions and 275 deletions.
diff --git a/arbi/src/base.rs b/arbi/src/base.rs
@@ -1,5 +1,5 @@
 /*
-Copyright 2024 Owain Davies
+Copyright 2024-2025 Owain Davies
 SPDX-License-Identifier: Apache-2.0 OR MIT
 */
 
@@ -159,6 +159,7 @@ impl Base {
     ///
     /// let b36 = Base::new(36).unwrap();
     /// ```
+    #[inline]
     pub fn new(value: u8) -> Result<Self, BaseError> {
         value.try_into()
     }
@@ -172,6 +173,7 @@ impl Base {
     /// let b10 = Base::new(10).unwrap();
     /// assert_eq!(b10.value(), 10);
     /// ```
+    #[inline]
     pub fn value(self) -> u8 {
         self.0
     }

diff --git a/arbi/src/bits.rs b/arbi/src/bits.rs
@@ -368,6 +368,7 @@ mod tests {
     #[cfg(test)]
     mod random {
         use super::*;
+        use alloc::vec;
 
         macro_rules! test_bit_ops_for_type {
             ($rng:expr, $die:expr) => {

diff --git a/arbi/src/builtin_int_methods/trailing_zeros.rs b/arbi/src/builtin_int_methods/trailing_zeros.rs
@@ -33,6 +33,7 @@ mod tests {
     use crate::util::test::{get_seedable_rng, get_uniform_die, Distribution};
     use crate::Arbi;
     use crate::{BitCount, DDigit, Digit};
+    use alloc::vec;
 
     macro_rules! assert_trailing_zeros {
         ($value:expr) => {

diff --git a/arbi/src/floor.rs b/arbi/src/floor.rs
diff --git a/arbi/src/lib.rs b/arbi/src/lib.rs
@@ -33,7 +33,6 @@ mod division;
 pub mod docs;
 mod exponentiation;
 mod fits;
-mod floor;
 mod fmt;
 mod from_double;
 mod from_integral;
@@ -96,8 +95,6 @@ type QDigit = u128;
 #[allow(dead_code)]
 type SQDigit = i128;
 
-const DBL_MAX_INT: u64 = 0x20000000000000; // 2 ** 53
-
 /// Arbitrary Precision Integer type.
 ///
 /// # Internal Representation

diff --git a/arbi/src/ops/bit/impls.rs b/arbi/src/ops/bit/impls.rs
@@ -377,6 +377,7 @@ mod tests {
     use super::BitwiseOp;
     use crate::util::test::{get_seedable_rng, get_uniform_die, Distribution};
     use crate::{Arbi, DDigit, Digit};
+    use alloc::{format, vec};
     use core::ops::RangeInclusive;
 
     struct BitwiseTestCase {

diff --git a/arbi/src/right_shift.rs b/arbi/src/right_shift.rs
@@ -214,6 +214,7 @@ mod test_arithmetic_rshift {
     use crate::{
         Arbi, Assign, BitCount, DDigit, Digit, SDDigit, SDigit, SQDigit,
     };
+    use alloc::vec;
 
     #[test]
     fn test_mark_a() {

diff --git a/arbi/src/to_double.rs b/arbi/src/to_double.rs
@@ -1,5 +1,5 @@
 /*
-Copyright 2024 Owain Davies
+Copyright 2024-2025 Owain Davies
 SPDX-License-Identifier: Apache-2.0 OR MIT
 */
 
@@ -61,7 +61,7 @@ mod tests {
     use super::*;
     use crate::util::test::float::*;
     use crate::util::test::{get_seedable_rng, get_uniform_die, Distribution};
-    use crate::{DDigit, QDigit, SDDigit, SQDigit, DBL_MAX_INT};
+    use crate::{DDigit, QDigit, SDDigit, SQDigit};
 
     #[test]
     fn smoke() {