Use QDigit in square algorithm if it is available #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the multiple-precision squaring algorithm used needs space for 3 times the width of a
Digit
and this is achieved by using two double digitsDDigit
to act as oneQDigit
.When
Digit::BITS
is 32 bits or less, an unsigned integer type with width equal to 4 times the width of aDigit
exists:QDigit
.This PR updates the algorithm to use
QDigit
explicitly if it is available, rather than implementQDigit
on the fly using twoDDigit
s.This improves maintainability and potentially, efficiency.