Make set of valid strings for from_str_radix()
consistent with primitives
#77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we change what constitutes a valid string slice in
from_str_radix()
,assign_str_radix()
,from_str_base()
, andassign_str_base()
functions so that it is consistent with the string slice expected byfrom_str_radix()
for primitive integer types (e.g.i32::from_str_radix()
).This is a BREAKING change, as previously, among other things, leading and trailing whitespace was permitted.
Moreover,
assign_str_radix()
andassign_str_base()
functions no longer maintain the guarantee that the original value will remain intact if a parsing error occurs. In particular, these functions no longer validate the entire string before assigning to the arbitrary precision integer's underlying buffer. A warning has been issued in their respective documentation. This is also a BREAKING change.Finally, we make from/assign string code much more maintainable by basing all functions on a single implementation:
assign_str_base()
.There is no performance degradation.