-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR#2 causes example file to no longer building on Windows. #3
Comments
thanks for the subscribe man, I will generate a new release, as son as possible ,that compiles on msvc |
these function: private_Universal_recv_all(int fd, void *buf, size_t n) , its a tricky solution that @SamuelHenriqueDeMoraisVitrio did afor windows , bacause windows dont have the flag: MSG_WAITALL (responsable to ensure all bytes were recived) , so he created a loop , for it ssize_t private_Universal_recv_all(int fd, void *buf, size_t n){
int max = 0;
int received;
while (max < n) {
received = recv(fd, buf + max, n - max, 0);
if (received <= 0) {
return received;
}
max += received;
}
return max;
} |
@Michaelangel007 can you downcrease your Universal Socket version, on your build to check if the error still occurs ? , probably your install_dependencies.sh its using 0.2.6 version |
aparently to these: |
Ithink , its fixed here |
Thanks! Merged PR #4 and the example builds correctly again on MSVC. |
I've merged PR#2.
I've updated the examples/example_simple.c with the new include
#include "src/one.c"
mentioned in PR #2 however this now does not build with MSVC.exeGenerates this error:
The line in question:
Likewise using the old filename with the new
#include "BearHttpsClientOne.c"
generates the same error:This line is not compiling:
This was previously compiling before the merge PR#2. I'm not sure what changed in the function
ssize_t private_Universal_recv_all(int fd, void *buf, size_t n)
.The text was updated successfully, but these errors were encountered: