Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requires to have helm version 3.x installed #1904

Closed
wants to merge 1 commit into from
Closed

Requires to have helm version 3.x installed #1904

wants to merge 1 commit into from

Conversation

za
Copy link
Contributor

@za za commented Mar 12, 2025

issue: #1902

Hi @commjoen I was thinking to have this check. What do you think?

Checklist:

  • All the contributions made are solely the work of me and my co-authors
  • I tested the changes in this PR (if applicable)
  • I added unit tests to ensure my change works (when change in Java or on front-end code)
  • I added UI tests to ensure my UI changes work (when change in the overall UI, not needed if just adding a challenge)
  • The PR passes pre-commit hooks and automated tests

@za za requested review from commjoen and bendehaan as code owners March 12, 2025 07:35
commjoen
commjoen reviewed Mar 12, 2025
View reviewed changes
aws/k8s-vault-aws-start.sh
@@ -58,6 +58,17 @@ else
kubectl apply -f ../k8s/challenge33.yml
fi

# Get Helm version
HELM_VERSION=$(helm version --template "{{ .Version }}" | sed 's/^v//')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if the version output changes? We don't want to go this direction right now, sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Noted.

@za za closed this Mar 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commjoen commjoen commjoen left review comments

@bendehaan bendehaan Awaiting requested review from bendehaan bendehaan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@za @commjoen