Merge pull request #1729 from aharonphytech/fix/ios_request_permission_fallback

jennantilla · web-flow · commit 012f6de4fdb6 · 2024-08-15T16:00:13.000-07:00
[Bug] iOS - requestPermission fallbackToSettings fix
diff --git a/ios/RCTOneSignal/RCTOneSignalEventEmitter.m b/ios/RCTOneSignal/RCTOneSignalEventEmitter.m
@@ -287,7 +287,7 @@ + (void)sendEventWithName:(NSString *)name withBody:(NSDictionary *)body {
                  rejecter:(RCTPromiseRejectBlock)reject) {
     [OneSignal.Notifications requestPermission:^(BOOL accepted) {
         resolve(@(accepted));
-    } fallbackToSettings:fallbackToSettings];
+    } fallbackToSettings:[fallbackToSettings boolValue]];
 }
 
 RCT_EXPORT_METHOD(registerForProvisionalAuthorization:(RCTResponseSenderBlock)callback) {

Original file line number	Diff line number	Diff line change
`@@ -287,7 +287,7 @@ + (void)sendEventWithName:(NSString )name withBody:(NSDictionary )body {`
`287`	`287`	`rejecter:(RCTPromiseRejectBlock)reject) {`
`288`	`288`	`[OneSignal.Notifications requestPermission:^(BOOL accepted) {`
`289`	`289`	`resolve(@(accepted));`
`290`		`- } fallbackToSettings:fallbackToSettings];`
	`290`	`+ } fallbackToSettings:[fallbackToSettings boolValue]];`
`291`	`291`	`}`
`292`	`292`
`293`	`293`	`RCT_EXPORT_METHOD(registerForProvisionalAuthorization:(RCTResponseSenderBlock)callback) {`