Add unit tests

.github/workflows/umu-protonfixes.yml

@@ -1,4 +1,4 @@
-name: umu-protonfixes workflow
+name: umu-protonfixes
 
 on:
   push:
@@ -33,3 +33,6 @@ jobs:
     - name: Lint with Pylint
       run: |
         bash tools/lint.sh
+    - name: Test with unittest
+      run: |
+        python protonfixes_test.py

checks.py

@@ -1,7 +1,10 @@
 """ Run some tests and generate warnings for proton configuration issues
 """
 
-from .logger import log
+try:
+    from .logger import log
+except ImportError:
+    from logger import log
 
 
 def esync_file_limits() -> bool:

config.py

@@ -2,7 +2,11 @@
 """
 import os
 from configparser import ConfigParser
-from .logger import log
+try:
+    from .logger import log
+except ImportError:
+    from logger import log
+
 
 CONF_FILE = '~/.config/protonfixes/config.ini'
 DEFAULT_CONF = '''

fix.py

@@ -7,13 +7,20 @@
 import sys
 import urllib
 import json
-
 from functools import lru_cache
 from importlib import import_module
-from .util import check_internet
-from .checks import run_checks
-from .logger import log
-from . import config
+
+try:
+    from . import config
+    from .util import check_internet
+    from .checks import run_checks
+    from .logger import log
+except ImportError:
+    import config
+    from util import check_internet
+    from checks import run_checks
+    from logger import log
+
 
 
 @lru_cache
@@ -37,7 +44,7 @@ def get_game_id() -> str:
 def get_game_name() -> str:
     """ Trys to return the game name from environment variables
     """
-    if 'UMU_ID' in os.environ:
+    if os.environ.get('UMU_ID'):
         if os.path.isfile(os.environ['WINEPREFIX'] + '/game_title'):
             with open(os.environ['WINEPREFIX'] + '/game_title', 'r', encoding='utf-8') as file:
                 return file.readline()
@@ -68,22 +75,19 @@ def get_game_name() -> str:
             log.debug(f'IndexError occurred: {ex}')
         except UnicodeDecodeError as ex:
             log.debug(f'UnicodeDecodeError occurred: {ex}')
-    else:
-        try:
-            game_library = re.findall(r'.*/steamapps', os.environ['PWD'], re.IGNORECASE)[-1]
-            game_manifest = os.path.join(game_library, f'appmanifest_{get_game_id()}.acf')
-
-            with io.open(game_manifest, 'r', encoding='utf-8') as appmanifest:
-                for xline in appmanifest.readlines():
-                    if 'name' in xline.strip():
-                        name = re.findall(r'"[^"]+"', xline, re.UNICODE)[-1]
-                        return name
-        except OSError:
-            pass
-        except IndexError:
-            pass
-        except UnicodeDecodeError:
-            pass
+        return 'UNKNOWN'
+    try:
+        log.debug('UMU_ID is not in environment')
+        game_library = re.findall(r'.*/steamapps', os.environ['PWD'], re.IGNORECASE)[-1]
+        game_manifest = os.path.join(game_library, f'appmanifest_{get_game_id()}.acf')
+
+        with io.open(game_manifest, 'r', encoding='utf-8') as appmanifest:
+            for xline in appmanifest.readlines():
+                if 'name' in xline.strip():
+                    name = re.findall(r'"[^"]+"', xline, re.UNICODE)[-1]
+                    return name
+    except (OSError, IndexError, UnicodeDecodeError):
+        pass
 
     return 'UNKNOWN'
 
@@ -108,7 +112,11 @@ def get_store_name(store: str) -> str:
 def get_module_name(game_id: str, default: bool = False, local: bool = False) -> str:
     """ Creates the name of a gamefix module, which can be imported
     """
-    store = os.environ.get('STORE').lower() if os.environ.get('STORE') else 'steam'
+    store = 'umu'
+    if game_id.isnumeric():
+        store = 'steam'
+    elif os.environ.get('STORE'):
+        store = os.environ.get('STORE').lower()
 
     if store != 'steam':
         log.info(f'Non-steam game {get_game_name()} ({game_id})')