enable Reproducible Builds #21067
Open
enable Reproducible Builds #21067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wing328
reviewed
Apr 9, 2025
| @@ -1212,6 +1212,7 @@ | |||
| <properties> | |||
| <maven.compiler.source>11</maven.compiler.source> | |||
| <maven.compiler.target>11</maven.compiler.target> | |||
| <project.build.outputTimestamp>2025-04-09T17:14:21Z</project.build.outputTimestamp> | |||
There was a problem hiding this comment.
thanks for the PR. does it mean the build time stamp is hardcoded? do we need to update it regularly somehow?
There was a problem hiding this comment.
it is updated by versions:set when changing from SNAPSHOT to release and vice versa, or by maven-release-plugin
or you can also choose not to update but pick a purely conventional value
There was a problem hiding this comment.
I recommend to set it instead to the timestamp of the latest git commit which can be done on every build
<project.build.outputTimestamp>${git.commit.timestamp.datetime}</project.build.outputTimestamp>
using https://github.com/qoomon/maven-git-versioning-extension
|
when you've time, please review the CI test failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://maven.apache.org/guides/mini/guide-reproducible-builds.html
I just fixed what was reported by
mvn artifact:check-buildplan -Prelease, which is the minimum to get noise reductionmore checks are needed, as documented with install then verify + artifact:compare to see if additional noise needs to be removed: just starting with the first step