Don't setCurrentIndex on serial port combo
#56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Something got weird and then broke (PySide6-Essentials 6.6.1, 6.6.3) with QComboBox and trying to use the setCurrentIndex slot in another thread gives QBasicTimer::start: Timers cannot be started from another thread QObject::startTimer: Timers cannot be started from another thread errors when selecting the combo box afterwards. This was just a QoL feature so just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something got weird and then broke (PySide6-Essentials 6.6.1, 6.6.3) with
QComboBoxand trying to use thesetCurrentIndexslot in another thread giveserrors when selecting the combo box afterwards. This was just a QoL feature so just remove it.