Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the_od_bods data on pipeline run #3

Merged
merged 5 commits into from
Jan 26, 2023

Conversation

KarenJewell
Copy link
Member

@KarenJewell KarenJewell commented Jan 7, 2023

Description

Added commit action to the_od_bods repo for the /data folder only.

Motivation and Context

Addresses issue #2

How Has This Been Tested?

Ran action from branch

  • I ran a shorter version and the new parts worked: runs/3864027901. Successful commit on the_od_bods
  • the full version didn't work but seems to be because there were no changes to commit and chain failed - so outside of my change runs/3864057998

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@KarenJewell KarenJewell linked an issue Jan 7, 2023 that may be closed by this pull request
2 tasks
@KarenJewell KarenJewell changed the title 2 replace data on refresh Replace the_od_bods data on pipeline run Jan 7, 2023
@JackGilmore
Copy link
Member

Having also noticed from your test runs that the pipeline fails if there's no git changes to commit, we should probably put some error handling in for that and get it to notify us on Slack as it's highly unlikely for such an event to happen

@KarenJewell
Copy link
Member Author

Having also noticed from your test runs that the pipeline fails if there's no git changes to commit, we should probably put some error handling in for that and get it to notify us on Slack as it's highly unlikely for such an event to happen

Opened issue #5 for this. Will work on the other 2 requests some time this week.

@KarenJewell
Copy link
Member Author

bold move, but I'm going to go ahead and merge in time for tomorrow's refresh.

@KarenJewell KarenJewell merged commit 5d9a7b3 into main Jan 26, 2023
@KarenJewell KarenJewell deleted the 2-replace-data-on-refresh branch January 26, 2023 22:39
@KarenJewell
Copy link
Member Author

Forgot to mention successful test on shortened pipeline: runs/4019709605

@JackGilmore
Copy link
Member

bold move, but I'm going to go ahead and merge in time for tomorrow's refresh.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Replace the_od_bods/data/ with every pipeline run
2 participants