Skip to content

Remaining Branding Items #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 of 4 tasks
gibson9583 opened this issue May 30, 2025 · 3 comments · May be fixed by #112
Open
3 of 4 tasks

Remaining Branding Items #104

gibson9583 opened this issue May 30, 2025 · 3 comments · May be fixed by #112

Comments

@gibson9583
Copy link
Contributor

gibson9583 commented May 30, 2025

Round two. Additionally, the following things which are not marked specifically in the diff need to be addressed. Since these things are somewhat separate from the java code, it might be reasonable to just create a document pointing to where all of the changes need to be made.

  • question: do we want to change the plugin urls from nextgen.com?
  • todo: the default webadmin login page needs to be rebranded
  • todo: the swagger page still has Nextgen graphics at the top
  • todo: there are 3 package-info.java files that describe the User API packages which display in the javadoc pages and still refer to Mirth Connect.

Originally posted by @tonygermano in #23 (review)

@gibson9583 gibson9583 added this to the Technical Preview 1 milestone May 30, 2025
tonygermano added a commit to tonygermano/engine that referenced this issue May 31, 2025
Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
tonygermano added a commit to tonygermano/engine that referenced this issue May 31, 2025
Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
tonygermano added a commit to tonygermano/engine that referenced this issue May 31, 2025
Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
@tonygermano tonygermano linked a pull request Jun 3, 2025 that will close this issue
@sbraconnier
Copy link

Not sure it's the right place to put this or if it has already been discussed, but I did some testing and I think it would be nice to have a constant with an acronym "OIE" instead of the full name "Open Integration Engine". It would be then possible to use this constant when the full name doesn't fit, like for the "About Open Integration Engine" that doesn't fit in the main "Other" taskbar.

This line could be changed to:
addTask(TaskConstants.OTHER_ABOUT, String.format("About %s", BrandingConstants.PRODUCT_NAME_ACRONYM), String.format("View the about page for %s.", BrandingConstants.PRODUCT_NAME), "", new ImageIcon(com.mirth.connect.client.ui.Frame.class.getResource("images/information.png")), otherPane, null);

And the result would be :
Image

Instead of:
Image

@pacmano1
Copy link

pacmano1 commented Jun 6, 2025

We need to be careful with "OIE" I think. As an informal nickname it's fine. For the referenced screenshot "About" should be fine. Not a lawyer.

@sbraconnier
Copy link

I agree, "About" is totally fine.

tonygermano added a commit to tonygermano/engine that referenced this issue Jun 7, 2025
Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
tonygermano added a commit to tonygermano/engine that referenced this issue Jun 7, 2025
Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
tonygermano added a commit to tonygermano/engine that referenced this issue Jun 7, 2025
Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
tonygermano added a commit to tonygermano/engine that referenced this issue Jun 7, 2025
Fixed a typo in DicomListener

Signed-off-by: Tony Germano <tony@germano.name>
Issue: OpenIntegrationEngine#104
tonygermano added a commit to tonygermano/engine that referenced this issue Jun 7, 2025
Fix file permissions on a couple graphics that were marked executable.

Issue: OpenIntegrationEngine#104
Signed-off-by: Tony Germano <tony@germano.name>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants