Create launcher to parse vmoptions and start server #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #2 See README for details Signed-off-by: Tony Germano <tony@germano.name>
tonygermano
requested review from
jonbartels,
a team,
kayyagari,
gibson9583,
ssrowe,
kpalang and
pacmano1
and removed request for
a team
|
This has worked well in my testing (only on linux,) but it wasn't really what I intended for it to be. I figured I'd get it out for review so we can use it in the short term even if we end up replacing it with something else down the road. My plan was for it to be compiled to native using graalvm native-image, but I was having issues with that. It took a very long time to compile (around 6 minutes, compared to a few seconds for the jar version) produced a binary over 50MB in size, and then it was throwing exceptions during the shutdown hook. So, I decided for now it would just run using java (can be the same java version as what ultimately launches the server or a different one.) |
jonbartels
approved these changes
Apr 28, 2025
kayyagari
approved these changes
Apr 28, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2
See README for details
Main server build script and github actions have been modified to build and include the tool by default.