Skip to content

Issue #78 update PG drivers #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rogin
Copy link
Contributor

@rogin rogin commented May 10, 2025

Issue #78

Pulled latest v42.6.x from here. SHA1 hash verified. Sonatype showed it having zero vulnerabilities.

Could not find other PG jar at version "-405". Pulled latest "-408" version here. 2007 timestamp. SHA1 hash verified.

Code compiled w/exception of KeyEncryptorTest, which I deleted. All failed tests ignored.

Ignore the tool listing two renames - two files were deleted, and two files were added.

@rogin rogin force-pushed the update-postgresql branch from 7bcd46a to 32ec4ab Compare May 10, 2025 05:44
@tonygermano
Copy link
Member

I think I would not bother updating the driver for simplesender. I didn't even realize what that code did until I looked at it. It hasn't been touched in 13 years. That library was added 18 years ago. My best guess is that it was part of some undocumented test process. I don't believe it was included in the mirth distributions, and it doesn't look like it even gets built as part of the normal build process.

We probably need to evaluate to see if we want to get rid of it, and if we decide to keep it with the existing postgres functionality, it should be using a modern driver.

Copy link
Contributor

@jonbartels jonbartels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not update the JARS in simplesender. They are not packaged in the OIE server or client.

@jonbartels
Copy link
Contributor

@tonygermano - I agree with you. I filed #88

Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
@rogin rogin force-pushed the update-postgresql branch from 32ec4ab to 5c39642 Compare May 16, 2025 18:46
@rogin rogin marked this pull request as ready for review May 16, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants