Issue #78 update PG drivers #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I would not bother updating the driver for simplesender. I didn't even realize what that code did until I looked at it. It hasn't been touched in 13 years. That library was added 18 years ago. My best guess is that it was part of some undocumented test process. I don't believe it was included in the mirth distributions, and it doesn't look like it even gets built as part of the normal build process. We probably need to evaluate to see if we want to get rid of it, and if we decide to keep it with the existing postgres functionality, it should be using a modern driver. |
jonbartels
approved these changes
May 16, 2025
jonbartels
requested changes
May 16, 2025
|
@tonygermano - I agree with you. I filed #88 |
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
jonbartels
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #78
Pulled latest v42.6.x from here. SHA1 hash verified. Sonatype showed it having zero vulnerabilities.
Could not find other PG jar at version "-405". Pulled latest "-408" version here. 2007 timestamp. SHA1 hash verified.
Code compiled w/exception of KeyEncryptorTest, which I deleted. All failed tests ignored.
Ignore the tool listing two renames - two files were deleted, and two files were added.